qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, stefanb@linux.vnet.ibm.com,
	f4bug@amsat.org, cota@braap.org, stefanha@redhat.com,
	marcandre.lureau@redhat.com, pbonzini@redhat.com,
	aurelien@aurel32.net
Subject: Re: [PATCH v1 2/8] crypto: fix build with gcrypt enabled
Date: Thu, 3 Sep 2020 12:02:28 -0700	[thread overview]
Message-ID: <48499efb-ecbf-a388-4b19-bf6f1ade3a4b@linaro.org> (raw)
In-Reply-To: <20200903112107.27367-3-alex.bennee@linaro.org>

On 9/3/20 4:21 AM, Alex Bennée wrote:
> From: Daniel P. Berrangé <berrange@redhat.com>
> 
> If nettle is disabled and gcrypt enabled, the compiler and linker flags
> needed for gcrypt are not passed.
> 
> Gnutls was also not added as a dependancy when gcrypt is enabled.
> 
> Attempting to add the library dependencies at the same time as the
> source dependencies is error prone, as there are alot of different
> rules for picking which sources to use, and some of the source files
> use code level conditionals intead. It is thus clearer to add the
> library dependencies separately.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20200901133050.381844-2-berrange@redhat.com>
> ---
>  configure          |  2 ++
>  crypto/meson.build | 42 +++++++++++++++++++++++++++++++-----------
>  meson.build        |  5 +++++
>  3 files changed, 38 insertions(+), 11 deletions(-)

Tested-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~


  reply	other threads:[~2020-09-03 19:03 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 11:20 [PATCH v1 0/8] some testing and CI updates (re-greening) Alex Bennée
2020-09-03 11:21 ` [PATCH v1 1/8] CODING_STYLE.rst: flesh out our naming conventions Alex Bennée
2020-09-03 12:24   ` Paolo Bonzini
2020-09-03 11:21 ` [PATCH v1 2/8] crypto: fix build with gcrypt enabled Alex Bennée
2020-09-03 19:02   ` Richard Henderson [this message]
2020-09-03 11:21 ` [PATCH v1 3/8] tests/docker: add python3-setuptools the docker images Alex Bennée
2020-09-03 11:40   ` Thomas Huth
2020-09-03 19:30   ` Philippe Mathieu-Daudé
2020-09-03 11:21 ` [PATCH v1 4/8] usb-host: restrict workaround to new libusb versions Alex Bennée
2020-09-03 11:21 ` [PATCH v1 5/8] qemu-iotests: move check-block back to Makefiles Alex Bennée
2020-09-03 11:21 ` [PATCH v1 6/8] tests/meson.build: fp tests don't need CONFIG_TCG Alex Bennée
2020-09-03 12:10   ` Paolo Bonzini
2020-09-07  9:11     ` Alex Bennée
2020-09-07  9:41       ` Philippe Mathieu-Daudé
2020-09-07  9:55         ` Alex Bennée
2020-09-07 10:08           ` Philippe Mathieu-Daudé
2020-09-03 11:21 ` [PATCH v1 7/8] target/mips: simplify gen_compute_imm_branch logic Alex Bennée
2020-09-03 17:16   ` Richard Henderson
2020-09-03 11:21 ` [PATCH v1 8/8] migration: use pstrcpy to copy run state Alex Bennée
2020-09-03 12:13   ` Paolo Bonzini
2020-09-03 19:43     ` Philippe Mathieu-Daudé
2020-09-04 10:03       ` Alex Bennée
2020-09-03 11:34 ` [PATCH v1 0/8] some testing and CI updates (re-greening) Daniel P. Berrangé
2020-09-03 14:17   ` Thomas Huth
2020-09-03 14:38   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48499efb-ecbf-a388-4b19-bf6f1ade3a4b@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=cota@braap.org \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanb@linux.vnet.ibm.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).