From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K5Lwp-0004Lu-SW for qemu-devel@nongnu.org; Sun, 08 Jun 2008 10:32:43 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K5Lwl-0004KF-WC for qemu-devel@nongnu.org; Sun, 08 Jun 2008 10:32:43 -0400 Received: from [199.232.76.173] (port=33745 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K5Lwl-0004K3-Lm for qemu-devel@nongnu.org; Sun, 08 Jun 2008 10:32:39 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:55029) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K5Lwl-0002VM-Jn for qemu-devel@nongnu.org; Sun, 08 Jun 2008 10:32:39 -0400 Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172]) by fmmailgate02.web.de (Postfix) with ESMTP id AB5EBE0DB8E6 for ; Sun, 8 Jun 2008 16:32:38 +0200 (CEST) Received: from [88.64.22.242] (helo=[192.168.1.198]) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1K5Lwk-0000EX-00 for qemu-devel@nongnu.org; Sun, 08 Jun 2008 16:32:38 +0200 Message-ID: <484BED84.6070805@web.de> Date: Sun, 08 Jun 2008 16:32:36 +0200 From: Jan Kiszka MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Sender: jan.kiszka@web.de Subject: [Qemu-devel] [PATCH] Report unmapped addresses in memory_dump Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Instead of dumping incorrect (ie. previously read) data, report the invalid virtual address to the user. Signed-off-by: Jan Kiszka --- monitor.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) Index: b/monitor.c =================================================================== --- a/monitor.c +++ b/monitor.c @@ -591,7 +591,10 @@ static void memory_dump(int count, int f env = mon_get_cpu(); if (!env) break; - cpu_memory_rw_debug(env, addr, buf, l, 0); + if (cpu_memory_rw_debug(env, addr, buf, l, 0) < 0) { + term_printf(" Cannot access memory\n"); + break; + } } i = 0; while (i < l) {