From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1K5cpR-0006Fv-Tm
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 04:34:13 -0400
Received: from [199.232.76.173] (port=45891 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1K5cpQ-0006FE-Lw
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 04:34:12 -0400
Received: from mx1.polytechnique.org ([129.104.30.34]:55513)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1K5cpQ-0003Up-Lk
	for qemu-devel@nongnu.org; Mon, 09 Jun 2008 04:34:12 -0400
Message-ID: <484CEAFD.9020906@bellard.org>
Date: Mon, 09 Jun 2008 10:34:05 +0200
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [4705] Fix div[u]2.
References: <E1K5aWQ-0003Lh-Ac@cvs.savannah.gnu.org>
In-Reply-To: <E1K5aWQ-0003Lh-Ac@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

malc wrote:
> Revision: 4705
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=4705
> Author:   malc
> Date:     2008-06-09 06:06:25 +0000 (Mon, 09 Jun 2008)
> 
> Log Message:
> -----------
> Fix div[u]2.
> 
> Previous code assummed 32 by 32 bit divmod operation, and survived
> x86_64 test only by sheer luck. MIPS wasn't so forgiving.

Are you sure it is needed ? div[u]2 support in currently optional in 
TCG. On some hosts such as PowerPC, implementing div[u] directly is 
simpler. rem[u] can be implemented generically then.

Fabrice.