* [Qemu-devel] [PATCH] SVM: Fix segment attribute clobbering
@ 2008-06-09 12:42 Alexander Graf
0 siblings, 0 replies; only message in thread
From: Alexander Graf @ 2008-06-09 12:42 UTC (permalink / raw)
To: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 197 bytes --]
When SVM segment flags get stored in the VMCB, there is a certain chance
that they get clobbered by garbage bits. This patch ANDs the wanted bits
correctly and thus makes SVM work again.
Alex
[-- Attachment #2: qemu-svn-segflags.patch --]
[-- Type: text/x-patch, Size: 597 bytes --]
Index: target-i386/op_helper.c
===================================================================
--- target-i386/op_helper.c (revision 4707)
+++ target-i386/op_helper.c (working copy)
@@ -4767,7 +4767,7 @@
stl_phys(addr + offsetof(struct vmcb_seg, limit),
sc->limit);
stw_phys(addr + offsetof(struct vmcb_seg, attrib),
- (sc->flags >> 8) | ((sc->flags >> 12) & 0x0f00));
+ ((sc->flags >> 8) & 0xff) | ((sc->flags >> 12) & 0x0f00));
}
static inline void svm_load_seg(target_phys_addr_t addr, SegmentCache *sc)
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-06-09 12:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-09 12:42 [Qemu-devel] [PATCH] SVM: Fix segment attribute clobbering Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).