From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K6Xed-0000pr-4y for qemu-devel@nongnu.org; Wed, 11 Jun 2008 17:14:51 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1K6Xec-0000p9-DC for qemu-devel@nongnu.org; Wed, 11 Jun 2008 17:14:50 -0400 Received: from [199.232.76.173] (port=36390 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K6Xec-0000ov-8Q for qemu-devel@nongnu.org; Wed, 11 Jun 2008 17:14:50 -0400 Received: from mail.windriver.com ([147.11.1.11]:54295 helo=mail.wrs.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1K6Xeb-0007WZ-UA for qemu-devel@nongnu.org; Wed, 11 Jun 2008 17:14:50 -0400 Message-ID: <48504043.6050406@windriver.com> Date: Wed, 11 Jun 2008 16:14:43 -0500 From: Jason Wessel MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Proposed fix broken RST response to a slirp redirect socket References: <485009A9.6000900@windriver.com> <20080611180739.GA20729@edgar.se.axis.com> <20080611193712.GB20729@edgar.se.axis.com> <4850313B.8030304@windriver.com> <20080611202937.GC20729@edgar.se.axis.com> In-Reply-To: <20080611202937.GC20729@edgar.se.axis.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Edgar E. Iglesias" Cc: qemu-devel@nongnu.org Edgar E. Iglesias wrote: > On Wed, Jun 11, 2008 at 03:10:35PM -0500, Jason Wessel wrote: > >> + int err; >> + socklen_t slen; >> + >> + err = errno; >> >> --- >> >> Probably don't need to set err to errno since you are collecting it with getsockopt >> > > Please note that the errno value is used when nn < 0. > > Oops :-) I stand corrected, I see how it fits together now. Cheers, Jason.