From: Richard Henderson <richard.henderson@linaro.org>
To: "Ilya Leoshkevich" <iii@linux.ibm.com>,
"Warner Losh" <imp@bsdimp.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Riku Voipio" <riku.voipio@iki.fi>,
"Laurent Vivier" <laurent@vivier.eu>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH v4 02/12] {linux,bsd}-user: Introduce get_task_state()
Date: Mon, 19 Feb 2024 10:46:53 -1000 [thread overview]
Message-ID: <485099f9-90fa-488a-9b45-3bbd43b48077@linaro.org> (raw)
In-Reply-To: <20240219141628.246823-3-iii@linux.ibm.com>
On 2/19/24 04:15, Ilya Leoshkevich wrote:
> A CPU's TaskState is stored in the CPUState's void *opaque field,
> accessing which is somewhat awkward due to having to use a cast.
> Introduce a wrapper and use it everywhere.
>
> Suggested-by: Alex Bennée<alex.bennee@linaro.org>
> Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com>
> ---
> bsd-user/bsd-file.h | 2 +-
> bsd-user/qemu.h | 5 +++++
> bsd-user/signal.c | 20 ++++++++++----------
> gdbstub/user-target.c | 4 ++--
> include/user/safe-syscall.h | 2 +-
> linux-user/aarch64/cpu_loop.c | 2 +-
> linux-user/arm/cpu_loop.c | 4 ++--
> linux-user/arm/signal.c | 2 +-
> linux-user/cris/cpu_loop.c | 2 +-
> linux-user/elfload.c | 6 +++---
> linux-user/hppa/signal.c | 2 +-
> linux-user/linuxload.c | 2 +-
> linux-user/m68k/cpu_loop.c | 2 +-
> linux-user/m68k/target_cpu.h | 2 +-
> linux-user/mips/cpu_loop.c | 2 +-
> linux-user/ppc/signal.c | 4 ++--
> linux-user/qemu.h | 5 +++++
> linux-user/riscv/cpu_loop.c | 2 +-
> linux-user/signal-common.h | 2 +-
> linux-user/signal.c | 30 +++++++++++++++---------------
> linux-user/syscall.c | 26 +++++++++++++-------------
> linux-user/vm86.c | 18 +++++++++---------
> linux-user/xtensa/signal.c | 2 +-
> plugins/api.c | 8 ++++----
> semihosting/arm-compat-semi.c | 8 ++++----
> 25 files changed, 87 insertions(+), 77 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2024-02-19 20:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 14:15 [PATCH v4 00/12] gdbstub: Implement follow-fork-mode child Ilya Leoshkevich
2024-02-19 14:15 ` [PATCH v4 01/12] gdbstub: Support disablement in a multi-threaded process Ilya Leoshkevich
2024-02-19 14:15 ` [PATCH v4 02/12] {linux,bsd}-user: Introduce get_task_state() Ilya Leoshkevich
2024-02-19 14:32 ` Warner Losh
2024-02-19 20:46 ` Richard Henderson [this message]
2024-02-19 14:15 ` [PATCH v4 03/12] {linux,bsd}-user: Update ts_tid after fork() Ilya Leoshkevich
2024-02-19 14:33 ` Warner Losh
2024-02-19 14:15 ` [PATCH v4 04/12] gdbstub: Introduce gdbserver_fork_start() Ilya Leoshkevich
2024-02-19 14:15 ` [PATCH v4 05/12] {linux,bsd}-user: Pass pid to fork_end() Ilya Leoshkevich
2024-02-19 14:15 ` [PATCH v4 06/12] {linux,bsd}-user: Pass pid to gdbserver_fork() Ilya Leoshkevich
2024-02-19 14:15 ` [PATCH v4 07/12] gdbstub: Call gdbserver_fork() both in parent and in child Ilya Leoshkevich
2024-02-19 14:15 ` [PATCH v4 08/12] gdbstub: Introduce gdb_handle_query_supported_user() Ilya Leoshkevich
2024-02-19 14:15 ` [PATCH v4 09/12] gdbstub: Introduce gdb_handle_set_thread_user() Ilya Leoshkevich
2024-02-19 14:15 ` [PATCH v4 10/12] gdbstub: Introduce gdb_handle_detach_user() Ilya Leoshkevich
2024-02-19 14:15 ` [PATCH v4 11/12] gdbstub: Implement follow-fork-mode child Ilya Leoshkevich
2024-02-19 14:16 ` [PATCH v4 12/12] tests/tcg: Add two follow-fork-mode tests Ilya Leoshkevich
2024-03-04 18:03 ` [PATCH v4 00/12] gdbstub: Implement follow-fork-mode child Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485099f9-90fa-488a-9b45-3bbd43b48077@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=iii@linux.ibm.com \
--cc=imp@bsdimp.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).