From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1K8uAK-0006oM-LP for qemu-devel@nongnu.org; Wed, 18 Jun 2008 05:41:20 -0400 Received: from [199.232.76.173] (port=50967 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1K8uAJ-0006nx-Va for qemu-devel@nongnu.org; Wed, 18 Jun 2008 05:41:20 -0400 Received: from mx1.polytechnique.org ([129.104.30.34]:48650) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1K8uAJ-0006uF-KI for qemu-devel@nongnu.org; Wed, 18 Jun 2008 05:41:19 -0400 Message-ID: <4858D83C.10407@bellard.org> Date: Wed, 18 Jun 2008 11:41:16 +0200 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] SVM: Trap on correct IP References: <48585805.9070706@suse.de> <4858961A.2010805@suse.de> In-Reply-To: <4858961A.2010805@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org Your patch introduces a bug in mwait. Try my commited patch instead. Fabrice. Alexander Graf wrote: > Alexander Graf wrote: >> Hi, >> >> Currently HLT always traps at the IP after the hlt instruction. SVM >> requires its trap on the instruction's IP though, which breaks the >> current implementation as soon as an HLT intercept occurs. >> >> This patch does the SVM intercept with an IP value before the HLT >> instruction. >> >> Alex >> >> Signed-off-by: Alexander Graf >> >> > This version should also fix MWAIT. > > Signed-off-by: Alexander Graf > >