From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] target-sh4/op.c:597: warning: cast to pointer from integer of different size
Date: Mon, 23 Jun 2008 08:29:17 +0200 [thread overview]
Message-ID: <485F42BD.80400@web.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 606 bytes --]
The warning above pointed me to some strange code. I guess this was
originally indented:
Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
Index: qemu/target-sh4/op.c
===================================================================
--- qemu.orig/target-sh4/op.c
+++ qemu/target-sh4/op.c
@@ -594,8 +594,8 @@ void OPPROTO op_shlr16_Rn(void)
void OPPROTO op_tasb_rN(void)
{
- cond_t(*(int8_t *) env->gregs[PARAM1] == 0);
- *(int8_t *) env->gregs[PARAM1] |= 0x80;
+ cond_t((env->gregs[PARAM1] & 0xff) == 0);
+ *(int8_t *) &env->gregs[PARAM1] |= 0x80;
RETURN();
}
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]
next reply other threads:[~2008-06-23 6:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 6:29 Jan Kiszka [this message]
2008-07-13 12:32 ` [Qemu-devel] [REMINDER] Re: target-sh4/op.c:597: warning: cast to pointer from integer of different size Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485F42BD.80400@web.de \
--to=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).