From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KAnCD-0006G3-BB for qemu-devel@nongnu.org; Mon, 23 Jun 2008 10:39:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KAnCB-0006F3-Ke for qemu-devel@nongnu.org; Mon, 23 Jun 2008 10:39:04 -0400 Received: from [199.232.76.173] (port=33461 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KAnCB-0006Ez-2k for qemu-devel@nongnu.org; Mon, 23 Jun 2008 10:39:03 -0400 Received: from lizzard.sbs.de ([194.138.37.39]:22804) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KAnCA-0004sw-Oq for qemu-devel@nongnu.org; Mon, 23 Jun 2008 10:39:03 -0400 Received: from mail1.sbs.de (localhost [127.0.0.1]) by lizzard.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id m5NEZn0T002441 for ; Mon, 23 Jun 2008 16:35:49 +0200 Received: from [139.25.109.167] (mchn012c.mchp.siemens.de [139.25.109.167] (may be forged)) by mail1.sbs.de (8.12.11.20060308/8.12.11) with ESMTP id m5NEZnTj017941 for ; Mon, 23 Jun 2008 16:35:49 +0200 Resent-To: qemu-devel@nongnu.org Resent-Message-Id: <485FB4C5.1020609@siemens.com> Message-ID: <485FB255.4010501@siemens.com> Date: Mon, 23 Jun 2008 16:25:25 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <485FB18E.1090801@siemens.com> In-Reply-To: <485FB18E.1090801@siemens.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH 4/15] Remove unused TB cflags Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org TranslationBlock.cflags is unused, now that no one is interested in CF_SINGLE_INSN anymore. Also the other CF_* flags have no users. So let's clean this up. Signed-off-by: Jan Kiszka --- exec-all.h | 4 ---- exec.c | 1 - target-i386/translate.c | 6 ++---- 3 files changed, 2 insertions(+), 9 deletions(-) Index: b/exec-all.h =================================================================== --- a/exec-all.h +++ b/exec-all.h @@ -123,10 +123,6 @@ typedef struct TranslationBlock { uint64_t flags; /* flags defining in which context the code was generated */ uint16_t size; /* size of target code for this block (1 <= size <= TARGET_PAGE_SIZE) */ - uint16_t cflags; /* compile flags */ -#define CF_TB_FP_USED 0x0002 /* fp ops are used in the TB */ -#define CF_FP_USED 0x0004 /* fp ops are used in the TB or in a chained TB */ -#define CF_SINGLE_INSN 0x0008 /* compile only a single instruction */ uint8_t *tc_ptr; /* pointer to the translated code */ /* next matching tb for physical address. */ Index: b/exec.c =================================================================== --- a/exec.c +++ b/exec.c @@ -1001,7 +1001,6 @@ TranslationBlock *tb_alloc(target_ulong return NULL; tb = &tbs[nb_tbs++]; tb->pc = pc; - tb->cflags = 0; return tb; } Index: b/target-i386/translate.c =================================================================== --- a/target-i386/translate.c +++ b/target-i386/translate.c @@ -7105,7 +7105,7 @@ static inline int gen_intermediate_code_ DisasContext dc1, *dc = &dc1; target_ulong pc_ptr; uint16_t *gen_opc_end; - int j, lj, cflags; + int j, lj; uint64_t flags; target_ulong pc_start; target_ulong cs_base; @@ -7114,7 +7114,6 @@ static inline int gen_intermediate_code_ pc_start = tb->pc; cs_base = tb->cs_base; flags = tb->flags; - cflags = tb->cflags; dc->pe = (flags >> HF_PE_SHIFT) & 1; dc->code32 = (flags >> HF_CS32_SHIFT) & 1; @@ -7210,8 +7209,7 @@ static inline int gen_intermediate_code_ the flag and abort the translation to give the irqs a change to be happen */ if (dc->tf || dc->singlestep_enabled || - (flags & HF_INHIBIT_IRQ_MASK) || - (cflags & CF_SINGLE_INSN)) { + (flags & HF_INHIBIT_IRQ_MASK)) { gen_jmp_im(pc_ptr - dc->cs_base); gen_eob(dc); break;