From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH qemu v2 04/13] memory: Move FlatView allocation to a helper
Date: Fri, 15 Sep 2017 11:02:33 +0200 [thread overview]
Message-ID: <485a3d8c-d44c-be20-6700-324d142d95cf@redhat.com> (raw)
In-Reply-To: <20170915084030.40988-5-aik@ozlabs.ru>
On 15/09/2017 10:40, Alexey Kardashevskiy wrote:
> -static void flatview_init(FlatView *view)
> +static FlatView *flatview_alloc(void)
> {
> + FlatView *view;
> +
> + view = g_new0(FlatView, 1);
> view->ref = 1;
> - view->ranges = NULL;
> - view->nr = 0;
> - view->nr_allocated = 0;
> +
> + return view;
> }
Maybe flatview_new for consistency with other functions? Otherwise
definitely a good idea.
Paolo
next prev parent reply other threads:[~2017-09-15 9:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 8:40 [Qemu-devel] [PATCH qemu v2 00/13] memory: Reduce memory use Alexey Kardashevskiy
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 01/13] memory: Postpone flatview and dispatch tree building till all devices are added Alexey Kardashevskiy
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 02/13] exec: Explicitely export target AS from address_space_translate_internal Alexey Kardashevskiy
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 03/13] memory: Open code FlatView rendering Alexey Kardashevskiy
2017-09-15 8:59 ` Paolo Bonzini
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 04/13] memory: Move FlatView allocation to a helper Alexey Kardashevskiy
2017-09-15 9:02 ` Paolo Bonzini [this message]
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 05/13] memory: Move AddressSpaceDispatch from AddressSpace to FlatView Alexey Kardashevskiy
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 06/13] memory: Remove AddressSpace pointer from AddressSpaceDispatch Alexey Kardashevskiy
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 07/13] memory: Switch memory from using AddressSpace to FlatView Alexey Kardashevskiy
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 08/13] memory: Cleanup after switching " Alexey Kardashevskiy
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 09/13] memory: Rename mem_begin/mem_commit/mem_add helpers Alexey Kardashevskiy
2017-09-15 9:10 ` Paolo Bonzini
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 10/13] memory: Move root MR from AddressSpace to FlatView Alexey Kardashevskiy
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 11/13] memory: Share FlatView's and dispatch trees between address spaces Alexey Kardashevskiy
2017-09-15 9:25 ` Paolo Bonzini
2017-09-16 0:58 ` Alexey Kardashevskiy
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 12/13] memory: Get rid of address_space_init_shareable Alexey Kardashevskiy
2017-09-15 8:40 ` [Qemu-devel] [PATCH qemu v2 13/13] memory: Add flat views to HMP "info mtree" Alexey Kardashevskiy
2017-09-15 9:39 ` [Qemu-devel] [PATCH qemu v2 00/13] memory: Reduce memory use no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=485a3d8c-d44c-be20-6700-324d142d95cf@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).