From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KB3md-0003iA-CF for qemu-devel@nongnu.org; Tue, 24 Jun 2008 04:21:47 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KB3mb-0003hj-Qa for qemu-devel@nongnu.org; Tue, 24 Jun 2008 04:21:46 -0400 Received: from [199.232.76.173] (port=41647 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KB3mb-0003hg-HD for qemu-devel@nongnu.org; Tue, 24 Jun 2008 04:21:45 -0400 Received: from mx2.suse.de ([195.135.220.15]:40091) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KB3mb-0003Xb-5h for qemu-devel@nongnu.org; Tue, 24 Jun 2008 04:21:45 -0400 Message-ID: <4860ADE0.2030305@suse.de> Date: Tue, 24 Jun 2008 10:18:40 +0200 From: Kevin Wolf MIME-Version: 1.0 References: <485FBE18.4090603@siemens.com> <20080623152348.GA16375@shareable.org> <485FC2BC.3040503@siemens.com> In-Reply-To: <485FC2BC.3040503@siemens.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RESENT][PATCH 2/2] x86: Issue reset on triple faults Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: qemu-devel@nongnu.org Jan Kiszka schrieb: > Jamie Lokier wrote: >> It might be worth distinguishing between >> triple-fault-used-by-guest-for-context-switch and triple faults which >> trigger a normal reset, and log only the latter. There's a >> standardish way of distinguishing them, which the BIOS should check. Well, that's certainly possible somehow. But then you need to rename the cpu_reset option to cpu_resets_suspected_to_be_errors. Let's keep it simple and just log all of them. >>> +#if !defined(CONFIG_USER_ONLY) >>> + if (env->old_exception == EXCP08_DBLE) { >>> + if (env->hflags & HF_SVMI_MASK) >>> + helper_vmexit(SVM_EXIT_SHUTDOWN, 0); >>> + >>> + if (loglevel & CPU_LOG_RESET) >>> + fprintf(logfile, "Triple fault\n"); >>> + >>> + qemu_system_reset_request(); >>> + return EXCP_HLT; >>> + } >>> +#endif >> When helper(SVM_EXIT_SHUTDOWN, 0) is called, should it still also call >> qemu_system_reset_request()? > > helper_vmexit() is not expected to return (cpu_loop_exit). Maybe a comment then? Kevin