From: Kevin Wolf <kwolf@suse.de>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [RESENT][PATCH 1/2] Log reset events
Date: Tue, 24 Jun 2008 11:07:36 +0200 [thread overview]
Message-ID: <4860B958.1010306@suse.de> (raw)
In-Reply-To: <485FBE12.5080100@siemens.com>
Jan Kiszka schrieb:
> Index: b/target-i386/helper.c
> ===================================================================
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -383,6 +383,11 @@ void cpu_reset(CPUX86State *env)
>
> memset(env, 0, offsetof(CPUX86State, breakpoints));
>
> + if (loglevel & CPU_LOG_RESET) {
> + fprintf(logfile, "CPU Reset (CPU %d)\n", env->cpu_index);
> + cpu_dump_state(env, logfile, fprintf, X86_DUMP_FPU | X86_DUMP_CCOP);
> + }
> +
> tlb_flush(env, 1);
>
> env->old_exception = -1;
I'd say you want to have the memset after the CPU dump, otherwise the
dump is quite boring. ;-) Did you change that by intention? Your last
patch still had the memset after the dump.
You can add a Signed-off-by: Kevin Wolf <kwolf@suse.de> to the next
version of the patch.
Kevin
next prev parent reply other threads:[~2008-06-24 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 15:15 [Qemu-devel] [RESENT][PATCH 1/2] Log reset events Jan Kiszka
2008-06-24 9:07 ` Kevin Wolf [this message]
2008-06-24 10:19 ` [Qemu-devel] [PATCH 1/2] Log reset events - v2 Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4860B958.1010306@suse.de \
--to=kwolf@suse.de \
--cc=jan.kiszka@siemens.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).