From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KB4Xu-0001bw-QU
	for qemu-devel@nongnu.org; Tue, 24 Jun 2008 05:10:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KB4Xs-0001aA-VN
	for qemu-devel@nongnu.org; Tue, 24 Jun 2008 05:10:38 -0400
Received: from [199.232.76.173] (port=38989 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KB4Xs-0001Zi-1S
	for qemu-devel@nongnu.org; Tue, 24 Jun 2008 05:10:36 -0400
Received: from ns.suse.de ([195.135.220.2]:57852 helo=mx1.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <kwolf@suse.de>) id 1KB4Xr-0005yz-E8
	for qemu-devel@nongnu.org; Tue, 24 Jun 2008 05:10:35 -0400
Message-ID: <4860B958.1010306@suse.de>
Date: Tue, 24 Jun 2008 11:07:36 +0200
From: Kevin Wolf <kwolf@suse.de>
MIME-Version: 1.0
References: <485FBE12.5080100@siemens.com>
In-Reply-To: <485FBE12.5080100@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RESENT][PATCH 1/2] Log reset events
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: qemu-devel@nongnu.org

Jan Kiszka schrieb:
> Index: b/target-i386/helper.c
> ===================================================================
> --- a/target-i386/helper.c
> +++ b/target-i386/helper.c
> @@ -383,6 +383,11 @@ void cpu_reset(CPUX86State *env)
>  
>      memset(env, 0, offsetof(CPUX86State, breakpoints));
>  
> +    if (loglevel & CPU_LOG_RESET) {
> +        fprintf(logfile, "CPU Reset (CPU %d)\n", env->cpu_index);
> +        cpu_dump_state(env, logfile, fprintf, X86_DUMP_FPU | X86_DUMP_CCOP);
> +    }
> +
>      tlb_flush(env, 1);
>  
>      env->old_exception = -1;

I'd say you want to have the memset after the CPU dump, otherwise the 
dump is quite boring. ;-) Did you change that by intention? Your last 
patch still had the memset after the dump.

You can add a Signed-off-by: Kevin Wolf <kwolf@suse.de> to the next 
version of the patch.

Kevin