From: Kevin Wolf <kwolf@suse.de>
To: Laurent Vivier <Laurent.Vivier@bull.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: improve I/O performance with cache=off
Date: Wed, 25 Jun 2008 10:43:01 +0200 [thread overview]
Message-ID: <48620515.4070306@suse.de> (raw)
In-Reply-To: <1214325634.3846.6.camel@frecb07144>
Hi Laurent,
Laurent Vivier schrieb:
> I modify this patch according Avi comments, and I'll repost it.
>
> Thank you for your comments.
It's certainly a good idea to add the change suggested by Avi. But don't
you think you'd better make a second patch out of it, on top of this
one? I feel that the patch to get_cluster_offset might not be too small
for itself.
Oh, and while you're at it... ;-) I think this function could use at
least some more comments, and splitting out some parts as new functions
could also help with its readability.
Kevin
next prev parent reply other threads:[~2008-06-25 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 14:38 [Qemu-devel] [PATCH] qcow2: improve I/O performance with cache=off Laurent Vivier
2008-06-23 2:50 ` Avi Kivity
2008-06-24 15:40 ` Kevin Wolf
2008-06-24 16:40 ` Laurent Vivier
2008-06-25 8:43 ` Kevin Wolf [this message]
2008-06-25 8:59 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48620515.4070306@suse.de \
--to=kwolf@suse.de \
--cc=Laurent.Vivier@bull.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).