From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KBQde-0007Hd-VU for qemu-devel@nongnu.org; Wed, 25 Jun 2008 04:46:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KBQdd-0007Fv-7A for qemu-devel@nongnu.org; Wed, 25 Jun 2008 04:46:02 -0400 Received: from [199.232.76.173] (port=45345 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KBQdd-0007Fk-2L for qemu-devel@nongnu.org; Wed, 25 Jun 2008 04:46:01 -0400 Received: from mx2.suse.de ([195.135.220.15]:45454) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KBQdc-0003Dl-Kw for qemu-devel@nongnu.org; Wed, 25 Jun 2008 04:46:00 -0400 Message-ID: <48620515.4070306@suse.de> Date: Wed, 25 Jun 2008 10:43:01 +0200 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qcow2: improve I/O performance with cache=off References: <1213972680.3859.34.camel@frecb07144> <4861156B.30707@suse.de> <1214325634.3846.6.camel@frecb07144> In-Reply-To: <1214325634.3846.6.camel@frecb07144> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-devel@nongnu.org Hi Laurent, Laurent Vivier schrieb: > I modify this patch according Avi comments, and I'll repost it. > > Thank you for your comments. It's certainly a good idea to add the change suggested by Avi. But don't you think you'd better make a second patch out of it, on top of this one? I feel that the patch to get_cluster_offset might not be too small for itself. Oh, and while you're at it... ;-) I think this function could use at least some more comments, and splitting out some parts as new functions could also help with its readability. Kevin