From: Eric Blake <eblake@redhat.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>,
"Michael S. Tsirkin" <mst@redhat.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Eduardo Habkost <ehabkost@redhat.com>,
linux-nvdimm <linux-nvdimm@lists.01.org>,
Qemu Developers <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files
Date: Fri, 8 Jun 2018 10:00:32 -0500 [thread overview]
Message-ID: <4865a48e-2653-b077-6656-acc5f1b49def@redhat.com> (raw)
In-Reply-To: <edcae62f-e3b6-6e25-60a5-843eeae89396@redhat.com>
On 06/08/2018 09:59 AM, Eric Blake wrote:
> On 06/07/2018 05:31 PM, Ross Zwisler wrote:
>> With a fully built QEMU I currently see the following with "git status":
>>
>> Untracked files:
>> (use "git add <file>..." to include in what will be committed)
>>
>> qapi/qapi-commands-job.c
>> qapi/qapi-commands-job.h
>> qapi/qapi-events-job.c
>> qapi/qapi-events-job.h
>> qapi/qapi-types-job.c
>> qapi/qapi-types-job.h
>> qapi/qapi-visit-job.c
>> qapi/qapi-visit-job.h
>>
>> These are all generated files. Ignore them.
>>
>> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
>> Cc: Kevin Wolf <kwolf@redhat.com>
>> Cc: Eric Blake <eblake@redhat.com>
>> Fixes: commit bf42508f24ee ("job: Introduce qapi/job.json")
>
> You're the third to post this:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-05/msg07280.html
> https://lists.gnu.org/archive/html/qemu-devel/2018-06/msg01624.html
Also, when sending a series, it's best to include a 0/5 cover letter
(the automated CI tooling handles that better, among other reasons).
You can use 'git config' to automatically send a cover letter for any
patch series > 1. For more tips,
https://wiki.qemu.org/Contribute/SubmitAPatch
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2018-06-08 15:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 22:31 [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files Ross Zwisler
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 2/5] acpi: "make check" should fail on asl mismatch Ross Zwisler
2018-06-07 23:09 ` Michael S. Tsirkin
2018-06-08 5:17 ` Thomas Huth
2018-06-08 15:34 ` Ross Zwisler
2018-06-08 15:59 ` Michael S. Tsirkin
2018-06-08 16:14 ` Peter Maydell
2018-06-08 16:21 ` Michael S. Tsirkin
2018-06-08 16:03 ` Michael S. Tsirkin
2018-06-08 16:16 ` Peter Maydell
2018-06-08 16:24 ` Michael S. Tsirkin
2018-06-08 17:23 ` Thomas Huth
2018-06-08 18:41 ` Michael S. Tsirkin
2018-06-08 19:56 ` Thomas Huth
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 3/5] hw/i386: Update SSDT table used by "make check" Ross Zwisler
2018-06-07 23:14 ` Michael S. Tsirkin
2018-06-08 14:24 ` Eric Blake
2018-06-08 16:00 ` Michael S. Tsirkin
2018-06-08 5:39 ` Thomas Huth
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 4/5] machine: fix some misspelled words Ross Zwisler
2018-06-08 5:38 ` Thomas Huth
2018-06-08 17:41 ` Ross Zwisler
2018-06-08 18:01 ` Eric Blake
2018-06-07 22:31 ` [Qemu-devel] [qemu PATCH 5/5] nvdimm: make persistence option symbolic Ross Zwisler
2018-06-08 19:34 ` Michael S. Tsirkin
2018-06-08 14:59 ` [Qemu-devel] [qemu PATCH 1/5] gitignore: ignore generated qapi job files Eric Blake
2018-06-08 15:00 ` Eric Blake [this message]
2018-06-08 15:36 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4865a48e-2653-b077-6656-acc5f1b49def@redhat.com \
--to=eblake@redhat.com \
--cc=dan.j.williams@intel.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=kwolf@redhat.com \
--cc=linux-nvdimm@lists.01.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ross.zwisler@linux.intel.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).