qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, richard.henderson@linaro.org,
	armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2] scripts: add script to convert multiline comments into 4-line format
Date: Fri, 14 Dec 2018 19:15:40 +0100	[thread overview]
Message-ID: <48697d08-5230-bba3-7de9-2aef7054a7ed@redhat.com> (raw)
In-Reply-To: <6e191a36-7283-ed82-5f1f-3a8f4f818d62@redhat.com>

On 14/12/18 19:06, Wainer dos Santos Moschetta wrote:
> 
> IIUC above block handles the lines between lead and trail. So it would
> fix (but it doesn't) this:
> 
> # cat foo
> /*
>  comment 1
>  comment 2
>  */
> 
> # scripts/fix-multiline-comments.sh foo
> /*
>  comment 1
>  comment 2
>  */

Not enough spaces :)  It would fix

 /*
    comment 1
    comment 2
  */

or what is actually found in QEMU:

   /* comment 1
      comment 2 */

Thanks,

Paolo

  reply	other threads:[~2018-12-14 18:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14  9:48 [Qemu-devel] [PATCH v2] scripts: add script to convert multiline comments into 4-line format Paolo Bonzini
2018-12-14 18:06 ` Wainer dos Santos Moschetta
2018-12-14 18:15   ` Paolo Bonzini [this message]
2018-12-14 18:22     ` Wainer dos Santos Moschetta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48697d08-5230-bba3-7de9-2aef7054a7ed@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=armbru@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).