From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1gXs09-000715-PQ
	for qemu-devel@nongnu.org; Fri, 14 Dec 2018 13:15:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1gXs05-0004Yp-RD
	for qemu-devel@nongnu.org; Fri, 14 Dec 2018 13:15:53 -0500
Received: from mx1.redhat.com ([209.132.183.28]:33916)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <pbonzini@redhat.com>) id 1gXs05-0004YG-Ja
	for qemu-devel@nongnu.org; Fri, 14 Dec 2018 13:15:49 -0500
References: <20181214094828.18343-1-pbonzini@redhat.com>
	<6e191a36-7283-ed82-5f1f-3a8f4f818d62@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <48697d08-5230-bba3-7de9-2aef7054a7ed@redhat.com>
Date: Fri, 14 Dec 2018 19:15:40 +0100
MIME-Version: 1.0
In-Reply-To: <6e191a36-7283-ed82-5f1f-3a8f4f818d62@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2] scripts: add script to convert
 multiline comments into 4-line format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, richard.henderson@linaro.org, armbru@redhat.com

On 14/12/18 19:06, Wainer dos Santos Moschetta wrote:
>=20
> IIUC above block handles the lines between lead and trail. So it would
> fix (but it doesn't) this:
>=20
> # cat foo
> /*
> =C2=A0comment 1
> =C2=A0comment 2
> =C2=A0*/
>=20
> # scripts/fix-multiline-comments.sh foo
> /*
> =C2=A0comment 1
> =C2=A0comment 2
> =C2=A0*/

Not enough spaces :)  It would fix

 /*
    comment 1
    comment 2
  */

or what is actually found in QEMU:

   /* comment 1
      comment 2 */

Thanks,

Paolo