[Qemu-devel] Re: [RESEND][PATCH] save/restore interrupt_request across snapshots

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

Paul Brook wrote:
>> Save interrupt_request state along with the cpu snapshot and restore it
>> properly. This also solves the bug that pending interrupts before
>> invocation of qemu_loadvm_state can tunnel into the resumed guest,
>> causing invalid IRQs there.
> 
> I just checked in a patch which is a superset of this functionality.

Nice cleanups!

( Well, except for 

   if (version_id != 3 && version_id != 4 && version_id != 5
       && version_id != 6)

:-> )

And after fixing this typo, it also works nicely:

Index: exec.c
===================================================================
--- exec.c	(Revision 4817)
+++ exec.c	(Arbeitskopie)
@@ -463,7 +463,7 @@ static int cpu_common_load(QEMUFile *f,
         return -EINVAL;
 
     qemu_get_be32s(f, &env->halted);
-    qemu_put_be32s(f, &env->interrupt_request);
+    qemu_get_be32s(f, &env->interrupt_request);
     tlb_flush(env, 1);
 
     return 0;

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]