From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KDnh2-0006DX-U7
	for qemu-devel@nongnu.org; Tue, 01 Jul 2008 17:47:20 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KDnh1-0006CJ-46
	for qemu-devel@nongnu.org; Tue, 01 Jul 2008 17:47:20 -0400
Received: from [199.232.76.173] (port=54546 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KDnh0-0006CF-Ty
	for qemu-devel@nongnu.org; Tue, 01 Jul 2008 17:47:18 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:47757)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1KDnh0-0007d2-FZ
	for qemu-devel@nongnu.org; Tue, 01 Jul 2008 17:47:18 -0400
Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172])
	by fmmailgate01.web.de (Postfix) with ESMTP id 056D9E606FE8
	for <qemu-devel@nongnu.org>; Tue,  1 Jul 2008 23:47:17 +0200 (CEST)
Received: from [88.64.25.246] (helo=[192.168.1.198])
	by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256)
	(WEB.DE 4.109 #226) id 1KDngy-0008N6-00
	for qemu-devel@nongnu.org; Tue, 01 Jul 2008 23:47:16 +0200
Message-ID: <486AA5DE.1000708@web.de>
Date: Tue, 01 Jul 2008 23:47:10 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4858F482.9050903@siemens.com> <486A598C.2000005@siemens.com>
	<200807012102.25714.paul@codesourcery.com>
In-Reply-To: <200807012102.25714.paul@codesourcery.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigD34135C54E75AA1AFA2AA179"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [RESEND][PATCH] save/restore interrupt_request
	across snapshots
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigD34135C54E75AA1AFA2AA179
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Paul Brook wrote:
>> Save interrupt_request state along with the cpu snapshot and restore i=
t
>> properly. This also solves the bug that pending interrupts before
>> invocation of qemu_loadvm_state can tunnel into the resumed guest,
>> causing invalid IRQs there.
>=20
> I just checked in a patch which is a superset of this functionality.

Nice cleanups!

( Well, except for=20

   if (version_id !=3D 3 && version_id !=3D 4 && version_id !=3D 5
       && version_id !=3D 6)

:-> )

And after fixing this typo, it also works nicely:

Index: exec.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- exec.c	(Revision 4817)
+++ exec.c	(Arbeitskopie)
@@ -463,7 +463,7 @@ static int cpu_common_load(QEMUFile *f,
         return -EINVAL;
=20
     qemu_get_be32s(f, &env->halted);
-    qemu_put_be32s(f, &env->interrupt_request);
+    qemu_get_be32s(f, &env->interrupt_request);
     tlb_flush(env, 1);
=20
     return 0;

Jan


--------------enigD34135C54E75AA1AFA2AA179
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkhqpeQACgkQniDOoMHTA+m8ngCdFwsD0ziVZnrrmmV0fS8VLxvq
SRYAn21G5YvxyU1Y4jIgCbsMPH9LebyK
=ZLJo
-----END PGP SIGNATURE-----

--------------enigD34135C54E75AA1AFA2AA179--