From: Jan Kiszka <jan.kiszka@web.de>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 7/13] Restore pc on watchpoint hits
Date: Fri, 04 Jul 2008 23:15:25 +0200 [thread overview]
Message-ID: <486E92ED.70802@web.de> (raw)
In-Reply-To: <200807042149.08008.paul@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 757 bytes --]
Paul Brook wrote:
> On Thursday 03 July 2008, Jan Kiszka wrote:
>> In order to provide accurate information about the triggering
>> instruction, this patch adds the required bits to restore the pc if the
>> access happened inside a TB. With the BP_STOP_BEFORE_ACCESS flag, the
>> watchpoint user can control if the debug trap should be issued on or
>> after the accessing instruction.
>
> I'm fairly sure this won't work. What happens when an interrupt occurs?
When in interrupt is raised before the watchpoint is re-triggered (after
restore), it might be handled first - hmm... Maybe this has to be
prevented to avoid inconsistencies (ie. no guest IRQ delivery when
watchpoints are pending). Will check again and update the patch.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
next prev parent reply other threads:[~2008-07-04 21:15 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 15:50 [Qemu-devel] [PATCH 0/13] Enhance debugging support - 2nd take Jan Kiszka
2008-07-03 15:56 ` [Qemu-devel] [PATCH 1/13] Return appropriate watch message to gdb Jan Kiszka
2008-07-03 15:57 ` [Qemu-devel] [PATCH 2/13] Refactor and enhance break/watchpoint API Jan Kiszka
2008-07-03 15:58 ` [Qemu-devel] [PATCH 3/13] Set mem_io_vaddr on io_read Jan Kiszka
2008-07-03 15:58 ` [Qemu-devel] [PATCH 4/13] Respect length of watchpoints Jan Kiszka
2008-07-03 15:59 ` [Qemu-devel] [PATCH 5/13] Introduce next_cflags Jan Kiszka
2008-07-04 22:03 ` [Qemu-devel] [PATCH 5/13] Introduce next_cflags - v2 Jan Kiszka
2008-07-03 15:59 ` [Qemu-devel] [PATCH 6/13] Switch self-modified code recompilation to next_cflags Jan Kiszka
2008-07-03 16:00 ` [Qemu-devel] [PATCH 7/13] Restore pc on watchpoint hits Jan Kiszka
2008-07-04 20:49 ` Paul Brook
2008-07-04 21:15 ` Jan Kiszka [this message]
2008-07-03 16:00 ` [Qemu-devel] [PATCH 8/13] Remove premature memop TB terminations Jan Kiszka
2008-07-03 16:01 ` [Qemu-devel] [PATCH 9/13] Improve debugging of SMP guests Jan Kiszka
2008-07-03 16:02 ` [Qemu-devel] [PATCH 10/13] Introduce BP_WATCHPOINT_HIT flag Jan Kiszka
2008-07-03 16:02 ` [Qemu-devel] [PATCH 11/13] Add debug exception hook Jan Kiszka
2008-07-03 16:03 ` [Qemu-devel] [PATCH 12/13] Introduce BP_CPU as a breakpoint type Jan Kiszka
2008-07-03 16:03 ` [Qemu-devel] [PATCH 13/13] x86: Debug register emulation Jan Kiszka
2008-07-11 10:40 ` [Qemu-devel] Re: [PATCH 0/13] Enhance debugging support - 2nd take Jan Kiszka
2008-08-20 14:45 ` [Qemu-devel] [RESEND][PATCH " Jan Kiszka
2008-08-20 14:47 ` [Qemu-devel] [RESEND][PATCH 1/13] Return appropriate watch message to gdb Jan Kiszka
2008-08-20 14:49 ` [Qemu-devel] [RESEND][PATCH 2/13] Refactor and enhance break/watchpoint API Jan Kiszka
2008-09-07 2:14 ` Anthony Liguori
2008-09-07 7:15 ` Aurelien Jarno
2008-09-08 8:42 ` [Qemu-devel] " Jan Kiszka
2008-09-07 19:11 ` [Qemu-devel] " Blue Swirl
2008-09-08 8:43 ` [Qemu-devel] " Jan Kiszka
2008-09-15 13:22 ` Jan Kiszka
2008-09-08 20:07 ` Jan Kiszka
2008-08-20 14:50 ` [Qemu-devel] [RESEND][PATCH 3/13] Set mem_io_vaddr on io_read Jan Kiszka
2008-08-20 14:51 ` [Qemu-devel] [RESEND][PATCH 4/13] Respect length of watchpoints Jan Kiszka
2008-08-20 14:52 ` [Qemu-devel] [RESEND][PATCH 5/13] Introduce next_cflags Jan Kiszka
2008-08-20 14:54 ` [Qemu-devel] [RESEND][PATCH 6/13] Switch self-modified code recompilation to next_cflags Jan Kiszka
2008-08-20 14:56 ` [Qemu-devel] [RESEND][PATCH 7/13] Restore pc on watchpoint hits Jan Kiszka
2008-08-20 14:57 ` [Qemu-devel] [RESEND][PATCH 8/13] Remove premature memop TB terminations Jan Kiszka
2008-08-20 14:59 ` [Qemu-devel] [RESEND][PATCH 10/13] Introduce BP_WATCHPOINT_HIT flag Jan Kiszka
2008-08-20 15:00 ` [Qemu-devel] [RESEND][PATCH 11/13] Add debug exception hook Jan Kiszka
2008-08-20 15:01 ` [Qemu-devel] [RESEND][PATCH 12/13] Introduce BP_CPU as a breakpoint type Jan Kiszka
2008-08-20 15:02 ` [Qemu-devel] [RESEND][PATCH 13/13] x86: Debug register emulation Jan Kiszka
2008-08-20 15:04 ` [Qemu-devel] [RESEND][PATCH 9/13] Improve debugging of SMP guests Jan Kiszka
2008-08-21 20:19 ` [Qemu-devel] [RESEND][PATCH 0/13] Enhance debugging support - 2nd take Anthony Liguori
2008-08-21 22:53 ` [Qemu-devel] " Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486E92ED.70802@web.de \
--to=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).