From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KEscr-0000x1-GS for qemu-devel@nongnu.org; Fri, 04 Jul 2008 17:15:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KEscp-0000wF-Ou for qemu-devel@nongnu.org; Fri, 04 Jul 2008 17:15:29 -0400 Received: from [199.232.76.173] (port=53669 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KEscp-0000w9-IR for qemu-devel@nongnu.org; Fri, 04 Jul 2008 17:15:27 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:51474) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KEscp-0006zU-LK for qemu-devel@nongnu.org; Fri, 04 Jul 2008 17:15:27 -0400 Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215]) by fmmailgate01.web.de (Postfix) with ESMTP id C76DAE67FDD5 for ; Fri, 4 Jul 2008 23:15:25 +0200 (CEST) Received: from [88.64.29.116] (helo=[192.168.1.198]) by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1KEscn-0000ot-00 for qemu-devel@nongnu.org; Fri, 04 Jul 2008 23:15:25 +0200 Message-ID: <486E92ED.70802@web.de> Date: Fri, 04 Jul 2008 23:15:25 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <486CF559.5090805@siemens.com> <486CF79C.8080308@siemens.com> <200807042149.08008.paul@codesourcery.com> In-Reply-To: <200807042149.08008.paul@codesourcery.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigC10618050B887C6416E2C7A0" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH 7/13] Restore pc on watchpoint hits Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC10618050B887C6416E2C7A0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Paul Brook wrote: > On Thursday 03 July 2008, Jan Kiszka wrote: >> In order to provide accurate information about the triggering >> instruction, this patch adds the required bits to restore the pc if th= e >> access happened inside a TB. With the BP_STOP_BEFORE_ACCESS flag, the >> watchpoint user can control if the debug trap should be issued on or >> after the accessing instruction. >=20 > I'm fairly sure this won't work. What happens when an interrupt occurs?= When in interrupt is raised before the watchpoint is re-triggered (after restore), it might be handled first - hmm... Maybe this has to be prevented to avoid inconsistencies (ie. no guest IRQ delivery when watchpoints are pending). Will check again and update the patch. Jan --------------enigC10618050B887C6416E2C7A0 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAkhuku0ACgkQniDOoMHTA+nJJACcDfY++7UUBqsum0H/ZtOB6RO8 0YEAn1Eo3RuEn5cZdXBJJKiIb2MP6yiW =V0/I -----END PGP SIGNATURE----- --------------enigC10618050B887C6416E2C7A0--