From: Richard Henderson <richard.henderson@linaro.org>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: Thomas Huth <thuth@redhat.com>,
Janosch Frank <frankja@linux.ibm.com>,
Cornelia Huck <cohuck@redhat.com>,
Halil Pasic <pasic@linux.ibm.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 1/2] s390x: Align vector registers to 16 bytes
Date: Wed, 29 May 2019 06:18:18 -0500 [thread overview]
Message-ID: <486e1998-0c28-cca8-6c80-4064eb2a8b8a@linaro.org> (raw)
In-Reply-To: <20190529072726.7875-2-david@redhat.com>
On 5/29/19 2:27 AM, David Hildenbrand wrote:
> 11e2bfef7990 ("tcg/i386: Use MOVDQA for TCG_TYPE_V128 load/store")
> revealed that the vregs are not aligned to 16 bytes. Align them to
> 16 bytes, to avoid segfault'ing on x86.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
> target/s390x/cpu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-05-29 11:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 7:27 [Qemu-devel] [PATCH v1 0/2] s390x: Fix vector register alignment David Hildenbrand
2019-05-29 7:27 ` [Qemu-devel] [PATCH v1 1/2] s390x: Align vector registers to 16 bytes David Hildenbrand
2019-05-29 11:18 ` Richard Henderson [this message]
2019-05-29 7:27 ` [Qemu-devel] [PATCH v1 2/2] s390x: Use uint64_t for vector registers David Hildenbrand
2019-05-29 10:08 ` Cornelia Huck
2019-05-29 11:18 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486e1998-0c28-cca8-6c80-4064eb2a8b8a@linaro.org \
--to=richard.henderson@linaro.org \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).