From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Thomas Huth <thuth@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org
Cc: S.E.Harris@kent.ac.uk, dovgaluk@ispras.ru,
me@xcancerberox.com.ar,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
mrolnik@gmail.com, imammedo@redhat.com,
aleksandar.m.mail@gmail.com
Subject: Re: [PATCH rc1 18/24] hw/avr: Introduce ATMEL_ATMEGA_MCU config
Date: Thu, 23 Jan 2020 18:27:27 +0100 [thread overview]
Message-ID: <486ecd04-381d-07d2-16b4-51b7a7b6ee7a@redhat.com> (raw)
In-Reply-To: <18202992-bb80-d873-89e0-d1c31ff3fd22@redhat.com>
On 1/23/20 6:04 AM, Thomas Huth wrote:
> On 23/01/2020 01.03, Richard Henderson wrote:
>> From: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>
>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>> Message-Id: <20200120220107.17825-13-f4bug@amsat.org>
>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>> ---
>> hw/avr/Kconfig | 5 +++++
>> 1 file changed, 5 insertions(+)
>> create mode 100644 hw/avr/Kconfig
>>
>> diff --git a/hw/avr/Kconfig b/hw/avr/Kconfig
>> new file mode 100644
>> index 0000000000..da3b10afec
>> --- /dev/null
>> +++ b/hw/avr/Kconfig
>> @@ -0,0 +1,5 @@
>> +config ATMEL_ATMEGA_MCU
>> + bool
>> + select ATMEL_TIMER16
>> + select ATMEL_USART
>> + select ATMEL_POWER
>
> Just my 0.02 €, but I'd rather squash it into the next patch.
You are correct. I used a preliminary patch because the 'sample' board
was still present in the series sent to Michael:
https://lists.gnu.org/archive/html/qemu-devel/2020-01/msg04384.html
Since Richard the Arduino boards replace it, we should squash this.
next prev parent reply other threads:[~2020-01-23 20:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 0:02 [PATCH rc1 00/24] target/avr merger Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 01/24] target/avr: Add outward facing interfaces and core CPU logic Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 02/24] target/avr: Add instruction helpers Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 03/24] target/avr: Add instruction translation - Registers definition Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 04/24] target/avr: Add instruction translation - Arithmetic and Logic Instructions Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 05/24] target/avr: Add instruction translation - Branch Instructions Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 06/24] target/avr: Add instruction translation - Data Transfer Instructions Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 07/24] target/avr: Add instruction translation - Bit and Bit-test Instructions Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 08/24] target/avr: Add instruction translation - MCU Control Instructions Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 09/24] target/avr: Add instruction translation - CPU main translation function Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 10/24] target/avr: Add instruction disassembly function Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 11/24] hw/char: Add limited support for Atmel USART peripheral Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 12/24] hw/timer: Add limited support for Atmel 16 bit timer peripheral Richard Henderson
2020-01-23 4:49 ` Thomas Huth
2020-01-23 17:29 ` Philippe Mathieu-Daudé
2020-01-23 0:02 ` [PATCH rc1 13/24] hw/misc: Add Atmel power device Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 14/24] target/avr: Add section about AVR into QEMU documentation Richard Henderson
2020-01-23 4:56 ` Thomas Huth
2020-01-24 0:33 ` Philippe Mathieu-Daudé
2020-01-23 0:02 ` [PATCH rc1 15/24] target/avr: Register AVR support with the rest of QEMU Richard Henderson
2020-01-23 0:02 ` [PATCH rc1 16/24] target/avr: Add machine none test Richard Henderson
2020-01-23 5:02 ` Thomas Huth
2020-01-23 0:03 ` [PATCH rc1 17/24] target/avr: Update MAINTAINERS file Richard Henderson
2020-01-23 0:03 ` [PATCH rc1 18/24] hw/avr: Introduce ATMEL_ATMEGA_MCU config Richard Henderson
2020-01-23 5:04 ` Thomas Huth
2020-01-23 17:27 ` Philippe Mathieu-Daudé [this message]
2020-01-23 0:03 ` [PATCH rc1 19/24] hw/avr: Add some ATmega microcontrollers Richard Henderson
2020-01-23 23:40 ` Philippe Mathieu-Daudé
2020-01-23 0:03 ` [PATCH rc1 20/24] hw/avr: Add some Arduino boards Richard Henderson
2020-01-23 0:03 ` [PATCH rc1 21/24] target/avr: Update build system Richard Henderson
2020-01-23 0:03 ` [PATCH rc1 22/24] tests/boot-serial-test: Test some Arduino boards (AVR based) Richard Henderson
2020-01-23 0:03 ` [PATCH rc1 23/24] tests/acceptance: Test the Arduino MEGA2560 board Richard Henderson
2020-01-23 0:03 ` [PATCH rc1 24/24] .travis.yml: Run the AVR acceptance tests Richard Henderson
2020-01-23 5:12 ` [PATCH rc1 00/24] target/avr merger Thomas Huth
2020-01-23 11:56 ` Michael Rolnik
2020-01-23 17:36 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=486ecd04-381d-07d2-16b4-51b7a7b6ee7a@redhat.com \
--to=philmd@redhat.com \
--cc=S.E.Harris@kent.ac.uk \
--cc=aleksandar.m.mail@gmail.com \
--cc=dovgaluk@ispras.ru \
--cc=f4bug@amsat.org \
--cc=imammedo@redhat.com \
--cc=me@xcancerberox.com.ar \
--cc=mrolnik@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).