qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@qumranet.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 0/2] Fix the monitor 'screendump' command
Date: Thu, 10 Jul 2008 16:20:22 +0300	[thread overview]
Message-ID: <48760C96.1010405@qumranet.com> (raw)
In-Reply-To: <1215695074-8939-1-git-send-email-avi@qumranet.com>

[-- Attachment #1: Type: text/plain, Size: 310 bytes --]

Avi Kivity wrote:
> The screendump command was recently broken in qemu-svn.  Since many
> test suites depend on the command, it's important to get it fixed.
>
> The following two patches do just that.
>   

Another patch is needed (attached).


-- 
error compiling committee.c: too many arguments to function


[-- Attachment #2: force-resize.patch --]
[-- Type: text/plain, Size: 546 bytes --]

diff --git a/console.c b/console.c
index 061135f..055a3f1 100644
--- a/console.c
+++ b/console.c
@@ -1334,7 +1334,8 @@ CharDriverState *text_console_init(DisplayState *ds, const char *p)
 
 void qemu_console_resize(QEMUConsole *console, int width, int height)
 {
-    if (console->g_width != width || console->g_height != height) {
+    if (console->g_width != width || console->g_height != height
+        || !console->ds->data) {
         console->g_width = width;
         console->g_height = height;
         if (active_console == console) {

      parent reply	other threads:[~2008-07-10 13:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-10 13:04 [Qemu-devel] [PATCH 0/2] Fix the monitor 'screendump' command Avi Kivity
2008-07-10 13:04 ` [Qemu-devel] [PATCH 1/2] fix vga screendump Avi Kivity
2008-07-10 13:04 ` [Qemu-devel] [PATCH 2/2] fix screendump with multiple consoles Avi Kivity
2008-07-10 13:20 ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48760C96.1010405@qumranet.com \
    --to=avi@qumranet.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).