[Qemu-devel] target-sh4/op.c:597: warning: cast to pointer from integer of different size

[Qemu-devel] target-sh4/op.c:597: warning: cast to pointer from integer of different size

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 606 bytes --]

The warning above pointed me to some strange code. I guess this was
originally indented:

Signed-off-by: Jan Kiszka <jan.kiszka@web.de>

Index: qemu/target-sh4/op.c
===================================================================
--- qemu.orig/target-sh4/op.c
+++ qemu/target-sh4/op.c
@@ -594,8 +594,8 @@ void OPPROTO op_shlr16_Rn(void)

 void OPPROTO op_tasb_rN(void)
 {
-    cond_t(*(int8_t *) env->gregs[PARAM1] == 0);
-    *(int8_t *) env->gregs[PARAM1] |= 0x80;
+    cond_t((env->gregs[PARAM1] & 0xff) == 0);
+    *(int8_t *) &env->gregs[PARAM1] |= 0x80;
     RETURN();
 }




[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]

[Qemu-devel] [REMINDER] Re: target-sh4/op.c:597: warning: cast to pointer from integer of different size

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 754 bytes --]

Jan Kiszka wrote:
> The warning above pointed me to some strange code. I guess this was
> originally indented:
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
> 
> Index: qemu/target-sh4/op.c
> ===================================================================
> --- qemu.orig/target-sh4/op.c
> +++ qemu/target-sh4/op.c
> @@ -594,8 +594,8 @@ void OPPROTO op_shlr16_Rn(void)
> 
>  void OPPROTO op_tasb_rN(void)
>  {
> -    cond_t(*(int8_t *) env->gregs[PARAM1] == 0);
> -    *(int8_t *) env->gregs[PARAM1] |= 0x80;
> +    cond_t((env->gregs[PARAM1] & 0xff) == 0);
> +    *(int8_t *) &env->gregs[PARAM1] |= 0x80;
>      RETURN();
>  }
> 

Problem still exists, patch still applies - does anyone take care of
this arch?

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]