From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KJ5pj-0002BA-CP
	for qemu-devel@nongnu.org; Wed, 16 Jul 2008 08:10:11 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KJ5pg-00029r-Fx
	for qemu-devel@nongnu.org; Wed, 16 Jul 2008 08:10:09 -0400
Received: from [199.232.76.173] (port=54238 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KJ5pg-00029l-AW
	for qemu-devel@nongnu.org; Wed, 16 Jul 2008 08:10:08 -0400
Received: from fmmailgate02.web.de ([217.72.192.227]:34514)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <jan.kiszka@web.de>) id 1KJ5pg-0005fI-RG
	for qemu-devel@nongnu.org; Wed, 16 Jul 2008 08:10:09 -0400
Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215])
	by fmmailgate02.web.de (Postfix) with ESMTP id 48EE6E5F6FB0
	for <qemu-devel@nongnu.org>; Wed, 16 Jul 2008 14:10:05 +0200 (CEST)
Received: from [88.65.249.33] (helo=[139.25.109.167])
	by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256)
	(WEB.DE 4.109 #226) id 1KJ5pc-0004zG-00
	for qemu-devel@nongnu.org; Wed, 16 Jul 2008 14:10:04 +0200
Message-ID: <487DE519.3030202@web.de>
Date: Wed, 16 Jul 2008 14:10:01 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <E1KJ5Dz-0006JQ-WD@cvs.savannah.gnu.org>
	<761ea48b0807160436s6fd84eb4p6982eb4660c7df04@mail.gmail.com>
In-Reply-To: <761ea48b0807160436s6fd84eb4p6982eb4660c7df04@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig2BBA81B3EBC1A19F03510B0E"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [4875] Remove unintended dereference,
 kills a warning (Jan Kiszka).
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig2BBA81B3EBC1A19F03510B0E
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Laurent Desnogues wrote:
> On Wed, Jul 16, 2008 at 1:31 PM, Andrzej Zaborowski <balrogg@gmail.com>=
 wrote:
>> Modified: trunk/target-sh4/op.c
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>> --- trunk/target-sh4/op.c       2008-07-16 04:45:12 UTC (rev 4874)
>> +++ trunk/target-sh4/op.c       2008-07-16 11:31:11 UTC (rev 4875)
>> @@ -594,8 +594,8 @@
>>
>>  void OPPROTO op_tasb_rN(void)
>>  {
>> -    cond_t(*(int8_t *) env->gregs[PARAM1] =3D=3D 0);
>> -    *(int8_t *) env->gregs[PARAM1] |=3D 0x80;
>> +    cond_t((env->gregs[PARAM1] && 0xff) =3D=3D 0);
>=20
> Guess that should be a single '&'.

Oh, ooh. Yes, please fix.

Thanks,
Jan


--------------enig2BBA81B3EBC1A19F03510B0E
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkh95RwACgkQniDOoMHTA+nebwCbBaoEzJZk/zcr1qC8sPLO0Hb6
COwAnifRAhAPFcZOcDrd/ElM/2AqaFI0
=G5xl
-----END PGP SIGNATURE-----

--------------enig2BBA81B3EBC1A19F03510B0E--