From: Paolo Bonzini <pbonzini@redhat.com>
To: l00284672 <lizhengui@huawei.com>,
stefanha@redhat.com, mreitz@redhat.com, kwolf@redhat.com
Cc: jiangyiwen@huawei.com, eric.fangyi@huawei.com,
qemu-devel@nongnu.org, qemu-block@nongnu.org,
wangjie88@huawei.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk
Date: Mon, 10 Jun 2019 18:03:13 +0200 [thread overview]
Message-ID: <487a3a9d-92b3-bed4-4082-5701cd4bd08d@redhat.com> (raw)
In-Reply-To: <49e6310d-1c1c-2379-47e6-7239e0058e78@huawei.com>
On 10/06/19 16:51, l00284672 wrote:
> The pread will hang in attaching disk just when backend storage network
> disconnection .
Would the "open" hang as well in that case?
> I think the locking range of qemu_global_mutex is too large when do qmp
> operation. what
> does the qemu_global_mutex really protect?
Basically everything.
> what is the risk of unlocking qemu_global_mutex in qmp?
It's not QMP; it's specifically the code that calls raw_probe_alignment.
Paolo
next prev parent reply other threads:[~2019-06-10 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 13:34 [Qemu-devel] [PATCH] file-posix: unlock qemu_global_mutex before pread when attach disk Zhengui li
2019-06-10 13:51 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
2019-06-10 14:51 ` l00284672
2019-06-10 16:03 ` Paolo Bonzini [this message]
2019-06-11 2:53 ` l00284672
2019-06-11 8:49 ` Kevin Wolf
2019-06-10 14:12 ` [Qemu-devel] " no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487a3a9d-92b3-bed4-4082-5701cd4bd08d@redhat.com \
--to=pbonzini@redhat.com \
--cc=eric.fangyi@huawei.com \
--cc=jiangyiwen@huawei.com \
--cc=kwolf@redhat.com \
--cc=lizhengui@huawei.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wangjie88@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).