From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1drYeF-0000sp-5v for qemu-devel@nongnu.org; Mon, 11 Sep 2017 20:01:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1drYeE-0004xD-CP for qemu-devel@nongnu.org; Mon, 11 Sep 2017 20:01:51 -0400 References: <20170911172022.4738-1-eblake@redhat.com> <20170911172022.4738-18-eblake@redhat.com> From: John Snow Message-ID: <487f96ab-d6d9-efd0-436f-cb67e7dfbe77@redhat.com> Date: Mon, 11 Sep 2017 20:01:38 -0400 MIME-Version: 1.0 In-Reply-To: <20170911172022.4738-18-eblake@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v7 17/38] libqos: Use explicit QTestState for remaining libqos operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: thuth@redhat.com, "open list:IDE" , "Aneesh Kumar K.V" , Jason Wang , armbru@redhat.com, Alexander Graf , Greg Kurz , "open list:sPAPR" , Gerd Hoffmann , Stefan Hajnoczi , pbonzini@redhat.com, David Gibson On 09/11/2017 01:20 PM, Eric Blake wrote: > Drop one more client of global_qtest by teaching all remaining > libqos stragglers to pass in an explicit QTestState. Change the > setting of global_qtest from being implicit in libqos' call to > qtest_start() to instead be explicit in all clients that are > still relying on global_qtest. > > Note that qmp_execute() can be greatly simplified in the process, > and that we also get rid of interpolation of a JSON string into a > temporary variable when qtest_qmp() can do it more reliably. > > Signed-off-by: Eric Blake > Reviewed-by: John Snow