From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KKOka-0003dU-Kr for qemu-devel@nongnu.org; Sat, 19 Jul 2008 22:34:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KKOkZ-0003cU-Cp for qemu-devel@nongnu.org; Sat, 19 Jul 2008 22:34:15 -0400 Received: from [199.232.76.173] (port=60628 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KKOkZ-0003cG-7r for qemu-devel@nongnu.org; Sat, 19 Jul 2008 22:34:15 -0400 Received: from py-out-1112.google.com ([64.233.166.176]:26710) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KKOkZ-000854-1J for qemu-devel@nongnu.org; Sat, 19 Jul 2008 22:34:15 -0400 Received: by py-out-1112.google.com with SMTP id p76so735020pyb.10 for ; Sat, 19 Jul 2008 19:34:13 -0700 (PDT) Message-ID: <4882A407.5060004@codemonkey.ws> Date: Sat, 19 Jul 2008 21:33:43 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: qemu: fix vga screendump References: <1216329580-20804-1-git-send-email-aliguori@us.ibm.com> <1216329580-20804-6-git-send-email-aliguori@us.ibm.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org andrzej zaborowski wrote: > 2008/7/17 Anthony Liguori : > >> From: Avi Kivity >> Commit 737d2050 ("Implement resolution switching in common console code") >> uses qemu_console_resize() instead of dpy_resize(). This means console->ds >> is examined instead of the VGA private ds, and the resize does not take place, >> leading to a segfault. >> >> Fix by modifying the DisplayState directly rather than swapping the pointer. >> > > The screen dumping is hacky but maybe it's a good idea to keep the > hacks local to hw/vga.c, with something like the following diff. I > think we need to fix the screen dumping globally (some graphic cards > will need fixing too). > I agree the screen dumping is pretty hacky right now. Instead of installing a new DisplayState, I've never understood why we can't just dump ds->data after an appropriate translation. I think your patch looks better, but I can also code up a new screen dumping mechanism that doesn't take over DisplayState unless I'm missing something obvious. Regards, Anthony Liguori