From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KKere-0002Ah-Ns for qemu-devel@nongnu.org; Sun, 20 Jul 2008 15:46:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KKerd-0002AV-AP for qemu-devel@nongnu.org; Sun, 20 Jul 2008 15:46:38 -0400 Received: from [199.232.76.173] (port=45895 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KKerd-0002AS-6l for qemu-devel@nongnu.org; Sun, 20 Jul 2008 15:46:37 -0400 Received: from yw-out-1718.google.com ([74.125.46.155]:55700) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KKerd-0000WU-2r for qemu-devel@nongnu.org; Sun, 20 Jul 2008 15:46:37 -0400 Received: by yw-out-1718.google.com with SMTP id 6so454243ywa.82 for ; Sun, 20 Jul 2008 12:46:36 -0700 (PDT) Message-ID: <488395FE.3070500@codemonkey.ws> Date: Sun, 20 Jul 2008 14:46:06 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: qemu: fix vga screendump References: <1216329580-20804-1-git-send-email-aliguori@us.ibm.com> <1216329580-20804-6-git-send-email-aliguori@us.ibm.com> <4882A407.5060004@codemonkey.ws> <4883867B.5000000@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org andrzej zaborowski wrote: > 2008/7/20 Anthony Liguori : > >> andrzej zaborowski wrote: >> >>> 2008/7/20 Anthony Liguori : >>> With -no-graphic there's no ds->data, or it can have lower bpp than >>> what's otherwise available. >>> >>> >> Screen dumping with -no-graphic probably should just show a black screen >> anyway. >> > > I thought this was the main use case. You shouldn't need sdl installed > to perform the tests Avi talked about. > You could still just do -vnc none to achieve the same effect. >> I don't think a lower depth is really that big of a deal. It's what the >> user would be seeing anyway. The simplicity seems really nice to me. >> >> >>>> I think your patch looks better, but I can also code up a new screen >>>> dumping >>>> mechanism that doesn't take over DisplayState unless I'm missing >>>> something >>>> obvious. >>>> >>>> >>> It's worth a try, dumping ds->data is perhaps the way to go but >>> ds->depth is being set to 32bit and various video cards are optimised >>> on the assumption that ds->depth doesn't change, so maybe there should >>> be a notification callback. >>> >>> >> Yeah, that's a bug BTW and AFAIK it's only a problem with VMware VGA. >> > > AFAIK also at least three other adapters. > Really? Which ones? I think both std-vga and cirrus are fine. Regards, Anthony Liguori