From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KKguL-0005Dy-SR
	for qemu-devel@nongnu.org; Sun, 20 Jul 2008 17:57:33 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KKguK-0005Dj-B4
	for qemu-devel@nongnu.org; Sun, 20 Jul 2008 17:57:33 -0400
Received: from [199.232.76.173] (port=46072 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KKguK-0005Dg-6T
	for qemu-devel@nongnu.org; Sun, 20 Jul 2008 17:57:32 -0400
Received: from py-out-1112.google.com ([64.233.166.181]:54169)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KKguK-0000LP-8u
	for qemu-devel@nongnu.org; Sun, 20 Jul 2008 17:57:32 -0400
Received: by py-out-1112.google.com with SMTP id p76so872401pyb.10
	for <qemu-devel@nongnu.org>; Sun, 20 Jul 2008 14:57:31 -0700 (PDT)
Message-ID: <4883B4A8.9080402@codemonkey.ws>
Date: Sun, 20 Jul 2008 16:56:56 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: qemu: fix vga screendump
References: <1216329580-20804-1-git-send-email-aliguori@us.ibm.com>	<1216329580-20804-6-git-send-email-aliguori@us.ibm.com>	<fb249edb0807190736p3903c589r86586b61ad21f7cb@mail.gmail.com>	<4882A407.5060004@codemonkey.ws>	<fb249edb0807201007s177f8a18x30f19db4ab61080c@mail.gmail.com>	<4883867B.5000000@codemonkey.ws>	<fb249edb0807201228v3f748206x6e43e62c0abed250@mail.gmail.com>	<488395FE.3070500@codemonkey.ws>
	<fb249edb0807201308s7fa3d436ke06ecf91f7c0a14@mail.gmail.com>
In-Reply-To: <fb249edb0807201308s7fa3d436ke06ecf91f7c0a14@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

andrzej zaborowski wrote:
> 2008/7/20 Anthony Liguori <anthony@codemonkey.ws>:
>   
>> andrzej zaborowski wrote:
>>     
>>> 2008/7/20 Anthony Liguori <anthony@codemonkey.ws>:
>>>
>>>       
>>>> andrzej zaborowski wrote:
>>>>
>>>>         
>>>>> 2008/7/20 Anthony Liguori <anthony@codemonkey.ws>:
>>>>>  With -no-graphic there's no ds->data, or it can have lower bpp than
>>>>> what's otherwise available.
>>>>>
>>>>>
>>>>>           
>>>> Screen dumping with -no-graphic probably should just show a black screen
>>>> anyway.
>>>>
>>>>         
>>> I thought this was the main use case. You shouldn't need sdl installed
>>> to perform the tests Avi talked about.
>>>
>>>       
>> You could still just do -vnc none to achieve the same effect.
>>     
>
> What I mean is it should be totally independent of that and of X on
> host, if you want to perform comparisons on the bitmaps (and for
> various other reasons).
>   

-vnc none gives a consistent depth of 32-bit.

FWIW, I have a different approach to doing what Avi describes that uses 
a VNC client.  The advantage of this is that you can have a lot more 
control over the pixel format to avoid this sort of problem in the first 
place.

Regards,

Anthony Liguori