From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qcow2 - safe on kill? safe on power fail?
Date: Tue, 22 Jul 2008 09:11:23 -0500 [thread overview]
Message-ID: <4885EA8B.5050908@codemonkey.ws> (raw)
In-Reply-To: <48857926.5020708@qumranet.com>
Avi Kivity wrote:
> Journalling is so out of fashion. It's better to sequence the
> operations so that failure results in a leak instead of corruption.
Since the metadata is being updated synchronously, you could probably
get away with a pretty simple journal. Maybe even a single field that
contains the offset you are allocating which then gets reset once the
allocation was completed.
When QEMU starts up again, it can look at that field, and if it's not 0,
check for anomalies in the allocation, prune that portion of the tree,
and then start the guest. That's a few more writes but it's already a
slow path so it should be okay.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-07-22 14:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-05 21:18 [Qemu-devel] Signal handling and qcow2 image corruption David Barrett
2008-03-05 21:55 ` Anthony Liguori
2008-03-05 23:48 ` David Barrett
2008-03-06 6:57 ` Avi Kivity
2008-07-21 18:10 ` [Qemu-devel] qcow2 - safe on kill? safe on power fail? Jamie Lokier
2008-07-21 19:43 ` Anthony Liguori
2008-07-21 21:26 ` Jamie Lokier
2008-07-21 22:14 ` Anthony Liguori
2008-07-21 23:47 ` Jamie Lokier
2008-07-22 6:06 ` Avi Kivity
2008-07-22 14:08 ` Anthony Liguori
2008-07-22 14:46 ` Jamie Lokier
2008-07-22 19:11 ` Avi Kivity
2008-07-22 14:32 ` Jamie Lokier
2008-07-21 22:00 ` Andreas Schwab
2008-07-21 22:15 ` Anthony Liguori
2008-07-21 22:22 ` David Barrett
2008-07-21 22:50 ` Anthony Liguori
2008-07-22 6:07 ` Avi Kivity
2008-07-22 14:11 ` Anthony Liguori [this message]
2008-07-22 14:36 ` Avi Kivity
2008-07-22 16:16 ` Jamie Lokier
2008-07-22 19:13 ` Avi Kivity
2008-07-22 20:04 ` Jamie Lokier
2008-07-22 21:25 ` Avi Kivity
2008-07-22 14:22 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4885EA8B.5050908@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).