From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] Fix SDL problems with BGR displays
Date: Tue, 22 Jul 2008 17:10:41 -0500 [thread overview]
Message-ID: <48865AE1.4010305@us.ibm.com> (raw)
In-Reply-To: <1DCE177A-FDF8-4DFA-B0FE-AF85605439F0@web.de>
Andreas Färber wrote:
> Hi,
>
> Am 22.07.2008 um 22:51 schrieb Anthony Liguori:
>
>> From: Avi Kivity <avi@qumranet.com>
>>
>> kvm: qemu: revert qemu's sdl.c rev 1.40
>>
>> this fixes problems with bgr displays.
>
> What problems exactly are you fixing? Could other backends such as
> Cocoa be affected, too?
The original commit in question is 2974. I don't have the ability to
test Cocoa but we received a bug report about a BGR display regression
shortly after this commit. Reverting this particular part of the commit
made the problem go away. See
http://thread.gmane.org/gmane.comp.emulators.kvm.devel/7773
Perhaps Blue Swirl can comment if reverting this part of the patch
regresses some of the test cases he was working with when he committed
the original patch?
Regards,
Anthony Liguori
next prev parent reply other threads:[~2008-07-22 22:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 20:51 [Qemu-devel] [PATCH 1/3] Fix SDL problems with BGR displays Anthony Liguori
2008-07-22 20:51 ` [Qemu-devel] [PATCH 2/3] Fix task register type after reset Anthony Liguori
2008-07-22 20:51 ` [Qemu-devel] [PATCH 3/3] Fix -daemonize option Anthony Liguori
2008-07-22 21:25 ` [Qemu-devel] [PATCH 1/3] Fix SDL problems with BGR displays Andreas Färber
2008-07-22 22:10 ` Anthony Liguori [this message]
2008-07-23 7:39 ` Blue Swirl
2008-07-23 13:21 ` Anthony Liguori
2008-07-23 15:19 ` Blue Swirl
2008-07-23 15:22 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48865AE1.4010305@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).