From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KLQ4i-000684-R1
	for qemu-devel@nongnu.org; Tue, 22 Jul 2008 18:11:16 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KLQ4h-00067A-SO
	for qemu-devel@nongnu.org; Tue, 22 Jul 2008 18:11:16 -0400
Received: from [199.232.76.173] (port=44656 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KLQ4h-000671-Nt
	for qemu-devel@nongnu.org; Tue, 22 Jul 2008 18:11:15 -0400
Received: from e6.ny.us.ibm.com ([32.97.182.146]:48929)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <aliguori@us.ibm.com>) id 1KLQ4h-0003m5-Rq
	for qemu-devel@nongnu.org; Tue, 22 Jul 2008 18:11:15 -0400
Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236])
	by e6.ny.us.ibm.com (8.13.8/8.13.8) with ESMTP id m6MMDfNd024601
	for <qemu-devel@nongnu.org>; Tue, 22 Jul 2008 18:13:41 -0400
Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216])
	by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id
	m6MMB9WG235398
	for <qemu-devel@nongnu.org>; Tue, 22 Jul 2008 18:11:09 -0400
Received: from d01av02.pok.ibm.com (loopback [127.0.0.1])
	by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id
	m6MMB85L004126
	for <qemu-devel@nongnu.org>; Tue, 22 Jul 2008 18:11:09 -0400
Message-ID: <48865AE1.4010305@us.ibm.com>
Date: Tue, 22 Jul 2008 17:10:41 -0500
From: Anthony Liguori <aliguori@us.ibm.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/3] Fix SDL problems with BGR displays
References: <1216759903-21779-1-git-send-email-aliguori@us.ibm.com>
	<1DCE177A-FDF8-4DFA-B0FE-AF85605439F0@web.de>
In-Reply-To: <1DCE177A-FDF8-4DFA-B0FE-AF85605439F0@web.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>

Andreas F=E4rber wrote:
> Hi,
>
> Am 22.07.2008 um 22:51 schrieb Anthony Liguori:
>
>> From: Avi Kivity <avi@qumranet.com>
>>
>> kvm: qemu: revert qemu's sdl.c rev 1.40
>>
>> this fixes problems with bgr displays.
>
> What problems exactly are you fixing? Could other backends such as=20
> Cocoa be affected, too?

The original commit in question is 2974.  I don't have the ability to=20
test Cocoa but we received a bug report about a BGR display regression=20
shortly after this commit.  Reverting this particular part of the commit=20
made the problem go away.  See=20
http://thread.gmane.org/gmane.comp.emulators.kvm.devel/7773

Perhaps Blue Swirl can comment if reverting this part of the patch=20
regresses some of the test cases he was working with when he committed=20
the original patch?

Regards,

Anthony Liguori