From: Jan Kiszka <jan.kiszka@web.de>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix page_find_alloc for 32-bit use on 64-bit hosts
Date: Wed, 23 Jul 2008 16:42:05 +0200 [thread overview]
Message-ID: <4887433D.3080509@web.de> (raw)
In-Reply-To: <200807231326.00691.paul@codesourcery.com>
[-- Attachment #1: Type: text/plain, Size: 696 bytes --]
Paul Brook wrote:
> On Sunday 13 July 2008, Jan Kiszka wrote:
>> page_find_alloc, used e.g. for TB allocation, is not safe on 64-bit
>> hosts for 32-bit guests. Patch below fixes this by requesting new pages
>> only from the guest-reachable address range.
>
> I'm pretty sure this is wrong. The structures allocated by page_find_alloc do
> not need to be accessible by the guest. In fact it's better if they are
> outside the guest address space.
Bet we have "addr = h2g(p);" in page_find_alloc(), ie. we expect to
retrieve a valid guest address (for use with page_set_flag). Something
is borken here, but you can surely better tell us what precisely than
I'm able to.
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]
prev parent reply other threads:[~2008-07-23 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-13 20:28 [Qemu-devel] [PATCH] linux-user: Fix page_find_alloc for 32-bit use on 64-bit hosts Jan Kiszka
2008-07-23 12:26 ` Paul Brook
2008-07-23 14:42 ` Jan Kiszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4887433D.3080509@web.de \
--to=jan.kiszka@web.de \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).