From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLgDf-0002iZ-Lm for qemu-devel@nongnu.org; Wed, 23 Jul 2008 11:25:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLgDe-0002hr-2E for qemu-devel@nongnu.org; Wed, 23 Jul 2008 11:25:35 -0400 Received: from [199.232.76.173] (port=35707 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLgDd-0002hj-NT for qemu-devel@nongnu.org; Wed, 23 Jul 2008 11:25:33 -0400 Received: from yx-out-1718.google.com ([74.125.44.152]:60931) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KLgDc-0003Y3-VI for qemu-devel@nongnu.org; Wed, 23 Jul 2008 11:25:33 -0400 Received: by yx-out-1718.google.com with SMTP id 3so428166yxi.82 for ; Wed, 23 Jul 2008 08:25:29 -0700 (PDT) Message-ID: <48874D4A.8000604@codemonkey.ws> Date: Wed, 23 Jul 2008 10:24:58 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3] Always use nonblocking mode for qemu_chr_open_fd. References: <488688E3.105@codemonkey.ws> <20080723082413.GA2291@redhat.com> <48871A7E.5030501@redhat.com> <20080723121510.GJ2291@redhat.com> <48872979.4050107@redhat.com> <48873F17.4030101@redhat.com> In-Reply-To: <48873F17.4030101@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Gerd Hoffmann wrote: > Hi, > > >> Which means we need our own code for ptys and can't use the generic fd >> functions. I'll go trying cooking up a patch ... >> > > Comments on this one? > Checking every 100ms for every pty device really makes me cringe. Why is libvirt using ptys in the first place? Why not use unix sockets? They don't have these problems with state tracking. Regards, Anthony Liguori > cheers, > Gerd > >