From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KLgKr-0005Uc-Jd
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 11:33:01 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KLgKq-0005UM-Cd
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 11:33:00 -0400
Received: from [199.232.76.173] (port=36674 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KLgKq-0005UF-0s
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 11:33:00 -0400
Received: from yw-out-1718.google.com ([74.125.46.158]:61060)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KLgKp-0004lT-KJ
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 11:32:59 -0400
Received: by yw-out-1718.google.com with SMTP id 6so1133488ywa.82
	for <qemu-devel@nongnu.org>; Wed, 23 Jul 2008 08:32:58 -0700 (PDT)
Message-ID: <48874F0B.3040609@codemonkey.ws>
Date: Wed, 23 Jul 2008 10:32:27 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/3] Always use nonblocking mode
	for	qemu_chr_open_fd.
References: <E1KJqa3-00067A-KN@mariner.uk.xensource.com>
	<488688E3.105@codemonkey.ws> <20080723082413.GA2291@redhat.com>
	<48871A7E.5030501@redhat.com> <20080723121510.GJ2291@redhat.com>
	<48872979.4050107@redhat.com> <48873F17.4030101@redhat.com>
	<48874D4A.8000604@codemonkey.ws> <20080723153133.GL2291@redhat.com>
In-Reply-To: <20080723153133.GL2291@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org

Daniel P. Berrange wrote:
> On Wed, Jul 23, 2008 at 10:24:58AM -0500, Anthony Liguori wrote:
>   
>> Gerd Hoffmann wrote:
>>     
>>>  
>>>       
>>>> Which means we need our own code for ptys and can't use the generic fd
>>>> functions.  I'll go trying cooking up a patch ...
>>>>         
>>> Comments on this one?
>>>  
>>>       
>> Checking every 100ms for every pty device really makes me cringe.
>>
>> Why is libvirt using ptys in the first place?  Why not use unix 
>> sockets?  They don't have these problems with state tracking.
>>     
>
> The application using libvirt chooses to use PTYs - we're merely
> exposing the capability. The virt-console program for interacting
> with serial ports uses PTYs because its a configuration that historically
> works with both Xen and KVM. It could equally use UNIX sockets, but it'd
> still be desirable for PTYs to work better
>   

Okay, I'd strongly suggest migrating to something other than ptys.

Regards,

Anthony Liguori

> Daniel
>