From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLgwY-00084U-U8 for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:11:58 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLgwY-000840-9V for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:11:58 -0400 Received: from [199.232.76.173] (port=45505 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLgwY-00083x-3N for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:11:58 -0400 Received: from mx1.redhat.com ([66.187.233.31]:57074) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KLgwX-0002vm-ME for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:11:57 -0400 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id m6NGBvbY015274 for ; Wed, 23 Jul 2008 12:11:57 -0400 Received: from pobox.stuttgart.redhat.com (pobox.stuttgart.redhat.com [172.16.2.10]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m6NGBswp013096 for ; Wed, 23 Jul 2008 12:11:55 -0400 Received: from zweiblum.travel.kraxel.org (vpn-4-62.str.redhat.com [10.32.4.62]) by pobox.stuttgart.redhat.com (8.13.1/8.13.1) with ESMTP id m6NGBsCO024326 for ; Wed, 23 Jul 2008 12:11:54 -0400 Message-ID: <48875849.60200@redhat.com> Date: Wed, 23 Jul 2008 18:11:53 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3] Always use nonblocking mode for qemu_chr_open_fd. References: <488688E3.105@codemonkey.ws> <20080723082413.GA2291@redhat.com> <48871A7E.5030501@redhat.com> <20080723121510.GJ2291@redhat.com> <48872979.4050107@redhat.com> <48873F17.4030101@redhat.com> <48874D4A.8000604@codemonkey.ws> In-Reply-To: <48874D4A.8000604@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Anthony Liguori wrote: > Gerd Hoffmann wrote: >> >> Comments on this one? > > Checking every 100ms for every pty device really makes me cringe. Only when unconnected, and the interval can be changed. And I'm certainly open for better ideas ... cheers, Gerd