From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLhGD-000193-2d for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:32:17 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLhGB-00016y-1I for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:32:16 -0400 Received: from [199.232.76.173] (port=50988 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLhGA-00016p-SQ for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:32:14 -0400 Received: from yx-out-1718.google.com ([74.125.44.158]:12337) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KLhGA-00087X-OQ for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:32:14 -0400 Received: by yx-out-1718.google.com with SMTP id 3so438245yxi.82 for ; Wed, 23 Jul 2008 09:32:14 -0700 (PDT) Message-ID: <48875CEE.6000906@codemonkey.ws> Date: Wed, 23 Jul 2008 11:31:42 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/3] Always use nonblocking mode for qemu_chr_open_fd. References: <488688E3.105@codemonkey.ws> <20080723082413.GA2291@redhat.com> <48871A7E.5030501@redhat.com> <20080723121510.GJ2291@redhat.com> <48872979.4050107@redhat.com> <48873F17.4030101@redhat.com> <48874D4A.8000604@codemonkey.ws> <48875849.60200@redhat.com> In-Reply-To: <48875849.60200@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Gerd Hoffmann wrote: > Anthony Liguori wrote: > >> Gerd Hoffmann wrote: >> >>> Comments on this one? >>> >> Checking every 100ms for every pty device really makes me cringe. >> > > Only when unconnected, and the interval can be changed. > And I'm certainly open for better ideas ... > I don't have one. In xenconsoled, once a pty disconnected, it creates a new pty specifically because I don't think there's any sane way to detect reconnection. Regards, Anthony Liguori > cheers, > Gerd > > > >