From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KLhHf-0002V2-NA
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:33:47 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KLhHd-0002TC-4Q
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:33:47 -0400
Received: from [199.232.76.173] (port=58464 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KLhHc-0002T1-Qn
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:33:44 -0400
Received: from wr-out-0506.google.com ([64.233.184.238]:41737)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KLhHc-0008R3-KY
	for qemu-devel@nongnu.org; Wed, 23 Jul 2008 12:33:44 -0400
Received: by wr-out-0506.google.com with SMTP id c46so1605928wra.18
	for <qemu-devel@nongnu.org>; Wed, 23 Jul 2008 09:33:44 -0700 (PDT)
Message-ID: <48875D48.8030906@codemonkey.ws>
Date: Wed, 23 Jul 2008 11:33:12 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 2/3] Always use nonblocking
	mode	for	qemu_chr_open_fd.
References: <E1KJqa3-00067A-KN@mariner.uk.xensource.com>	<488688E3.105@codemonkey.ws>	<20080723082413.GA2291@redhat.com>	<48871A7E.5030501@redhat.com>	<20080723121510.GJ2291@redhat.com>	<48872979.4050107@redhat.com>	<48873F17.4030101@redhat.com>	<48874D4A.8000604@codemonkey.ws>	<20080723153133.GL2291@redhat.com>
	<48874F0B.3040609@codemonkey.ws> <4887598B.8070405@redhat.com>
In-Reply-To: <4887598B.8070405@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gerd Hoffmann wrote:
> Anthony Liguori wrote:
>   
>> Okay, I'd strongly suggest migrating to something other than ptys.
>>
>>     
>
> Granted.  That still leaves the question open what to do about the
> existing pty support.  Try to fix?  Leave it broken?  Drop from qemu?
>   

I really don't like introducing polling.  I think we should be trying to 
reduce the overall number of wake ups in QEMU, not add more.

I'm inclined to say that we simply declare that reconnecting to a PTY is 
broken/unsupported and strongly encourage the use of something else 
(like unix sockets).  That's always been my understanding FWIW.

Regards,

Anthony Liguori

> cheers,
>   Gerd
>
>