From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KM2tL-0000Sc-FQ
	for qemu-devel@nongnu.org; Thu, 24 Jul 2008 11:38:07 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KM2tJ-0000Pz-Hw
	for qemu-devel@nongnu.org; Thu, 24 Jul 2008 11:38:07 -0400
Received: from [199.232.76.173] (port=33542 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KM2tJ-0000PZ-BD
	for qemu-devel@nongnu.org; Thu, 24 Jul 2008 11:38:05 -0400
Received: from py-out-1112.google.com ([64.233.166.176]:31186)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KM2tI-0002IH-Vx
	for qemu-devel@nongnu.org; Thu, 24 Jul 2008 11:38:05 -0400
Received: by py-out-1112.google.com with SMTP id p76so2142053pyb.10
	for <qemu-devel@nongnu.org>; Thu, 24 Jul 2008 08:38:04 -0700 (PDT)
Message-ID: <4888A1BB.3010807@codemonkey.ws>
Date: Thu, 24 Jul 2008 10:37:31 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <E1KJqa3-00067A-KN@mariner.uk.xensource.com>	<488688E3.105@codemonkey.ws>
	<20080723082413.GA2291@redhat.com>	<48871A7E.5030501@redhat.com>
	<20080723121510.GJ2291@redhat.com>	<48872979.4050107@redhat.com>
	<48873F17.4030101@redhat.com>
In-Reply-To: <48873F17.4030101@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 2/3] Always use nonblocking mode for
	qemu_chr_open_fd.
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>

Gerd Hoffmann wrote:
>   Hi,
> 
>> Which means we need our own code for ptys and can't use the generic fd
>> functions.  I'll go trying cooking up a patch ...
> 
> Comments on this one?

If this is the best we can do (and I certainly hope we can do better), 
then I would at least like to see the interval bumped up to a second. 
I'd also like to see the qemu_mod_timer API extended to accept timeouts 
in milliseconds or seconds such that the later can be coalesced into a 
single wake-up.

An alternative implementation would be to use one timer for all PTY 
devices but I think adding a qemu_mod_timer_sec() is a more useful 
general thing to do.

Regards,

Anthony Liguori

> cheers,
>   Gerd
> 
>