From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNUsZ-0005E5-Ts for qemu-devel@nongnu.org; Mon, 28 Jul 2008 11:43:20 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNUsW-0005BP-DJ for qemu-devel@nongnu.org; Mon, 28 Jul 2008 11:43:19 -0400 Received: from [199.232.76.173] (port=44189 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNUsV-0005BJ-Ra for qemu-devel@nongnu.org; Mon, 28 Jul 2008 11:43:15 -0400 Received: from mx1.redhat.com ([66.187.233.31]:35643) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNUsV-0002Qx-NO for qemu-devel@nongnu.org; Mon, 28 Jul 2008 11:43:15 -0400 Message-ID: <488DE90E.3080809@redhat.com> Date: Mon, 28 Jul 2008 17:43:10 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 3/7] xen: add console backend driver. References: <1217251078-6591-1-git-send-email-kraxel@redhat.com> <1217251078-6591-4-git-send-email-kraxel@redhat.com> <488DD4FF.9030400@codemonkey.ws> In-Reply-To: <488DD4FF.9030400@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org >> + >> +struct devops xen_console_ops = { >> > > I missed it in the previous patchset, but it would be nice to QEMU-ify > these things. For instance, 'struct xen_console' => 'XenConsole', > 'struct devopts' => 'XenDevOpts', etc. Hmm, I will if I have to. But I don't like that style very much and a quick grep through the qemu header files shows that the CapsStyle isn't used consequently everythere. I see a happy style mix. The core structures tend to be CapsStyle though ... cheers, Gerd -- http://kraxel.fedorapeople.org/xenner/