From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNUup-0006QZ-38 for qemu-devel@nongnu.org; Mon, 28 Jul 2008 11:45:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNUuo-0006Py-Hz for qemu-devel@nongnu.org; Mon, 28 Jul 2008 11:45:38 -0400 Received: from [199.232.76.173] (port=44305 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNUuo-0006Po-4b for qemu-devel@nongnu.org; Mon, 28 Jul 2008 11:45:38 -0400 Received: from mx1.redhat.com ([66.187.233.31]:43866) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNUun-00037z-DL for qemu-devel@nongnu.org; Mon, 28 Jul 2008 11:45:37 -0400 Message-ID: <488DE99C.2010201@redhat.com> Date: Mon, 28 Jul 2008 17:45:32 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 6/7] xen: add net backend driver. References: <1217251078-6591-1-git-send-email-kraxel@redhat.com> <1217251078-6591-7-git-send-email-kraxel@redhat.com> <488DD73C.7060302@codemonkey.ws> In-Reply-To: <488DD73C.7060302@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org Anthony Liguori wrote: > Gerd Hoffmann wrote: >> +static void checksum_calculate(uint8_t *data, int length) >> +{ > > The same thing is done in e1000, I believe. We'll also probably want to > be able to support this for virtio so this would be pretty good to make > common code. Good point, I'll split it into a separate patch and source file. cheers, Gerd -- http://kraxel.fedorapeople.org/xenner/