From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KNY1g-0006Bk-2z
	for qemu-devel@nongnu.org; Mon, 28 Jul 2008 15:04:56 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KNY1e-0006Am-8V
	for qemu-devel@nongnu.org; Mon, 28 Jul 2008 15:04:55 -0400
Received: from [199.232.76.173] (port=60018 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KNY1e-0006AW-39
	for qemu-devel@nongnu.org; Mon, 28 Jul 2008 15:04:54 -0400
Received: from an-out-0708.google.com ([209.85.132.248]:61793)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KNY1d-0002wg-M4
	for qemu-devel@nongnu.org; Mon, 28 Jul 2008 15:04:53 -0400
Received: by an-out-0708.google.com with SMTP id d18so1710008and.130
	for <qemu-devel@nongnu.org>; Mon, 28 Jul 2008 12:04:53 -0700 (PDT)
Message-ID: <488E1834.4000509@codemonkey.ws>
Date: Mon, 28 Jul 2008 14:04:20 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/7] xen: add console backend driver.
References: <1217251078-6591-1-git-send-email-kraxel@redhat.com>
	<1217251078-6591-4-git-send-email-kraxel@redhat.com>
	<488DD4FF.9030400@codemonkey.ws> <488DE90E.3080809@redhat.com>
In-Reply-To: <488DE90E.3080809@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org

Gerd Hoffmann wrote:
>>> +
>>> +struct devops xen_console_ops = {
>>>   
>>>       
>> I missed it in the previous patchset, but it would be nice to QEMU-ify
>> these things.  For instance, 'struct xen_console' => 'XenConsole',
>> 'struct devopts' => 'XenDevOpts', etc.
>>     
>
> Hmm, I will if I have to.
>
> But I don't like that style very much and a quick grep through the qemu
> header files shows that the CapsStyle isn't used consequently
> everythere.  I see a happy style mix.  The core structures tend to be
> CapsStyle though ...
>   

I much prefer the Linux style myself, but I prefer consistency over any 
particular style.  I think it would be good to modify the code to be 
consistent with the rest of the core QEMU structure.

Regards,

Anthony Liguori

> cheers,
>   Gerd
>
>