From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KNu6w-0005pN-8J
	for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:39:50 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KNu6u-0005oj-SF
	for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:39:49 -0400
Received: from [199.232.76.173] (port=52766 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KNu6u-0005oe-H3
	for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:39:48 -0400
Received: from wr-out-0506.google.com ([64.233.184.238]:17192)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1KNu6u-0002HT-9k
	for qemu-devel@nongnu.org; Tue, 29 Jul 2008 14:39:48 -0400
Received: by wr-out-0506.google.com with SMTP id c46so80wra.18
	for <qemu-devel@nongnu.org>; Tue, 29 Jul 2008 11:39:47 -0700 (PDT)
Message-ID: <488F63BE.5060804@codemonkey.ws>
Date: Tue, 29 Jul 2008 13:38:54 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH]: Fix i2c_bus_save, which fixes KVM live
	migration
References: <488EBEFC.5040603@redhat.com>	
	<fb249edb0807290659s2eaa6f45ue02abe5907f22128@mail.gmail.com>	
	<200807291918.55451.paul@codesourcery.com>
	<fb249edb0807291135u64fbc9efh513622f1c74239ce@mail.gmail.com>
In-Reply-To: <fb249edb0807291135u64fbc9efh513622f1c74239ce@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: andrzej zaborowski <balrogg@gmail.com>
Cc: Paul Brook <paul@codesourcery.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org

andrzej zaborowski wrote:
> 2008/7/29 Paul Brook <paul@codesourcery.com>:
>   
>> No they aren't. I2C also supports 10-bit addressing.
>>     
>
> Addresses in qemu are still <= 8-bit, for example i2c_slave_load()
> assumes this and current i2c api users do.
>   

But for the save/restore format, if the spec can support 10-bit 
addressing, then we should use be16s to avoid having to change 
save/restore format if we ever expand the supported address size.

Regards,

Anthony Liguori

> Regards
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>