From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNunC-0007K5-Fe for qemu-devel@nongnu.org; Tue, 29 Jul 2008 15:23:30 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNunB-0007IZ-2n for qemu-devel@nongnu.org; Tue, 29 Jul 2008 15:23:30 -0400 Received: from [199.232.76.173] (port=58789 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNunA-0007IR-QZ for qemu-devel@nongnu.org; Tue, 29 Jul 2008 15:23:28 -0400 Received: from wr-out-0506.google.com ([64.233.184.232]:23498) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNunA-0001OK-QM for qemu-devel@nongnu.org; Tue, 29 Jul 2008 15:23:28 -0400 Received: by wr-out-0506.google.com with SMTP id c46so17371wra.18 for ; Tue, 29 Jul 2008 12:23:28 -0700 (PDT) Message-ID: <488F6E0E.2070504@codemonkey.ws> Date: Tue, 29 Jul 2008 14:22:54 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <488DC8B2.1070009@redhat.com> <20080728141515.GJ3196@minantech.com> <488DD98D.5010907@codemonkey.ws> <20080728153527.GA23771@minantech.com> In-Reply-To: <20080728153527.GA23771@minantech.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 0/3]: Add UUID command-line option Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gleb Natapov Cc: Chris Lalancette , qemu-devel@nongnu.org Gleb Natapov wrote: > On Mon, Jul 28, 2008 at 09:37:01AM -0500, Anthony Liguori wrote: > >> The backdoor interface is deprecated (from a VMware perspective) and is >> pretty terrible. I'll go through and do a more thorough review of the >> patches Chris posted but one thing I already know I'd like to see the >> > Review my last submission I linked above then too. > Applying the -uuid support without making use of that uuid anywhere isn't very useful. >> UUID plumbed through the SMBIOS tables for x86. That's a requirement in >> my mind for adding a -uuid option. I see no harm in also supporting the >> backdoor interface but the primary way to expose a UUID should be SMBIOS. >> > I am not sure I understand what you mean. Currently SMBIOS tables are > built by bochs bios and UUID backdoor is needed to fill in missing info. > But that patch that got pushed into the Bochs BIOS was wrong. So here's what I'd like to see in order to apply these patches: 1) A new patch to the Bochs BIOS that used CMOS to pass a UUID (or possibly an OF data structure as Blue Swirl suggested--although CMOS is safer). 2) The patches updated to work with this new interface. We should only support the VMware backdoor interface when it lets us reuse existing third-party code. We should not be creating new guest code (or BIOS code) that makes use of the backdoor interface. Regards, Anthony Liguori > -- > Gleb. >