From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KNv5o-0005TN-06 for qemu-devel@nongnu.org; Tue, 29 Jul 2008 15:42:44 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KNv5m-0005Si-5o for qemu-devel@nongnu.org; Tue, 29 Jul 2008 15:42:43 -0400 Received: from [199.232.76.173] (port=56097 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KNv5l-0005SP-LK for qemu-devel@nongnu.org; Tue, 29 Jul 2008 15:42:41 -0400 Received: from wr-out-0506.google.com ([64.233.184.224]:24777) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNv5l-0004pD-KU for qemu-devel@nongnu.org; Tue, 29 Jul 2008 15:42:41 -0400 Received: by wr-out-0506.google.com with SMTP id c46so25364wra.18 for ; Tue, 29 Jul 2008 12:42:40 -0700 (PDT) Message-ID: <488F728F.5020203@codemonkey.ws> Date: Tue, 29 Jul 2008 14:42:07 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] make e1000 use the checksuming code References: <488F23D2.4050906@redhat.com> In-Reply-To: <488F23D2.4050906@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann Gerd Hoffmann wrote: > Hi, > > This patch makes the e1000 nic driver use the checksumming code added > with the previous patch. That one better should be reviewed by someone > knowing the e1000 better than I do. I think I got it right though ... > Applied this and the v2 of the checksumming patch. I reviewed the checksumming code carefully for the e1000 and AFAICT, it's identical to the old behaviour. It also tested for packet corruption and everything appears okay. Thanks. Regards, Anthony Liguori > cheers, > Gerd > >