From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KO8TM-0003rX-U5 for qemu-devel@nongnu.org; Wed, 30 Jul 2008 05:59:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KO8TK-0003r9-BD for qemu-devel@nongnu.org; Wed, 30 Jul 2008 05:59:55 -0400 Received: from [199.232.76.173] (port=59579 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KO8TK-0003r6-2w for qemu-devel@nongnu.org; Wed, 30 Jul 2008 05:59:54 -0400 Received: from mx1.redhat.com ([66.187.233.31]:54844) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KO8TJ-0001X2-VW for qemu-devel@nongnu.org; Wed, 30 Jul 2008 05:59:54 -0400 Message-ID: <48903B96.6030407@redhat.com> Date: Wed, 30 Jul 2008 11:59:50 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend driver References: <1217251078-6591-1-git-send-email-kraxel@redhat.com> <1217251078-6591-5-git-send-email-kraxel@redhat.com> <488DD618.5000504@codemonkey.ws> <16E84423-5C51-4CBA-9D56-04CDE09312DF@web.de> In-Reply-To: <16E84423-5C51-4CBA-9D56-04CDE09312DF@web.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: xen-devel@lists.xensource.com, qemu-devel@nongnu.org Hi, >>> +/* A convenient function for munging pixels between different depths */ >>> +#define >>> BLT(SRC_T,DST_T,RSB,GSB,BSB,RDB,GDB,BDB) \ >>> + for (line = y ; line < (y+h) ; line++) { \ >> There are similar conversion macros in the VGA code. I don't know how >> practical it would be to reuse them but it's at least worth looking at. > > We created a file hw/pixel_ops.h to share code between vga.c and tcx.c, > probably it can be extended to serve Xen as well. Uhm, well, it isn't that easy. Unifying that looks like a big job in itself. pixel_ops.h as-is isn't very helpful for xen-framebuffer. The xen-framebuffer macro isn't very useful to others. What IMHO would be most useful is a set of generic conversion functions, operating on scanline level, much like the ones created by vga_template.h, but without dependencies on vga.c internals. cheers, Gerd -- http://kraxel.fedorapeople.org/xenner/