qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [PATCH] docs: Convert u2f.txt to rST
Date: Tue, 16 May 2023 18:54:52 +0200	[thread overview]
Message-ID: <48906545-7fdb-effb-8819-485a66226e2d@redhat.com> (raw)
In-Reply-To: <20230421163734.1152076-1-peter.maydell@linaro.org>

On 21/04/2023 18.37, Peter Maydell wrote:
> Convert the u2f.txt file to rST, and place it in the right place
> in our manual layout. The old text didn't fit very well into our
> manual style, so the new version ends up looking like a rewrite,
> although some of the original text is preserved:
> 
>   * the 'building' section of the old file is removed, since we
>     generally assume that users have already built QEMU
>   * some rather verbose text has been cut back
>   * document the passthrough device first, on the assumption
>     that's most likely to be of interest to users
>   * cut back on the duplication of text between sections
>   * format example command lines etc with rST
> 
> As it's a short document it seemed simplest to do this all
> in one go rather than try to do a minimal syntactic conversion
> and then clean up the wording and layout.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>   docs/system/device-emulation.rst |   1 +
>   docs/system/devices/usb-u2f.rst  |  93 ++++++++++++++++++++++++++
>   docs/system/devices/usb.rst      |   2 +-
>   docs/u2f.txt                     | 110 -------------------------------
>   4 files changed, 95 insertions(+), 111 deletions(-)
>   create mode 100644 docs/system/devices/usb-u2f.rst
>   delete mode 100644 docs/u2f.txt

I'm not an expert at all in this area, but your changes look sane to me, so:

Reviewed-by: Thomas Huth <thuth@redhat.com>



  parent reply	other threads:[~2023-05-16 16:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-21 16:37 [PATCH] docs: Convert u2f.txt to rST Peter Maydell
2023-05-09 13:09 ` Peter Maydell
2023-05-16 16:54 ` Thomas Huth [this message]
2023-05-18 10:41   ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48906545-7fdb-effb-8819-485a66226e2d@redhat.com \
    --to=thuth@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).